#A03. As Admin, I would like to update existing Hackathon events. #106

hebs87 · 2020-10-27T22:18:46Z

User Story ID:

#A03 (As Admin, I would like to update existing Hackathon events)
Feature

Description of PR:

All changes made are outlined below:

Added format attr to start_date and end_date HackathonForm field DateTimeInput widget to render existing datetime value correctly in frontend form when updating hackathon
Added update_hackathon view to enable editing hackathon in frontend form - uses create-event.html but pre-populates form fields with existing instance data:
- If user is not admin user, they are redirected to the hackathons list page
- Also adds current datetime to Hackathon instance's 'updated' field on save
- If hackathon has started, allow start date to be a date in the past
- If hackathon has not yet started and start_date is amended to a date in the past, error message is displayed
- If end_date is before start_date, error message is displayed
- If all checks pass, form is submitted and existing instance data is updated with new values
Added new URL for the view with the 'hackathon_id' arg to enable the correct event to be updated
Added logic to conditionally render 'Edit Hackathon' or 'Create Hacakathon' in create-event.html based on whether user is creating or updating hackathon
Amended hackathon_card.html with the following:
- Added 'EDIT' button (only for admin users) to each rendered hackathon card, which does the following:
  - If hackathon is in progress or ended, it triggers a confirmation modal warning (modal text changes depending on whether hackathon is in progress or ended):
    - Clicking 'NO' closes the modal
    - Clicking 'YES' redirects user to create-event.html template for editing relevant hackathon
  - If hackathon hasn't started yet, the user is taken to the create-event.html template without triggering the warning modal
  - Field values are pre-populated and user will have the ability to update them

Tests:

Manually tested all implemented functionality, which is all working as expected.
Validated all code in relevant validators and all passed - HTML validator threw errors for Django template tags, but no other errors.

Know bugs/errors:

No known bugs or errors after testing.

Screenshots:

Does this introduce a breaking change

Yes
[] No

…ow selecting past date for start date

… or in progress hackathons

…rectly in edit form

…ent.html

stefdworschak

LGTM

@hebs87 please have a quick look at my comments and let me know when I can merge it.

stefdworschak · 2020-10-28T16:19:18Z

hackathon/views.py

+
+    if request.method == 'GET':
+
+        template = "hackathon/create-event.html"


Don't think you need to declare the template, you can just pass it directly in the render function

This is just a personal preference, but if the preference here is to pass it in directly then that's cool. I've made the change, it'll be visible when I push it to the existing PR 👍

stefdworschak · 2020-10-28T16:19:32Z

hackathon/views.py

+    hackathon = get_object_or_404(Hackathon, pk=hackathon_id)
+
+    if request.method == 'GET':
+


Please remove the unneeded blank line

Done, this will be visible when I push the change to the existing PR.

stefdworschak · 2020-10-28T16:22:16Z

hackathon/urls.py

@@ -1,9 +1,10 @@
 from django.urls import path

-from .views import HackathonListView, create_hackathon, delete_hackathon
+from .views import HackathonListView, create_hackathon, update_hackathon, delete_hackathon


This line is too long as per PEP8 it should be less than 79 chars. Please make sure that all of the lines/files adhere to this.

Done, this will be visible once I push the changes to the existing PR.

stefdworschak · 2020-10-28T16:23:19Z

hackathon/views.py

+            messages.success(request, f'Thanks, {hackathon.display_name} has been successfully updated!')
+        return redirect("hackathon:hackathon-list")
+
+    pass


Can you please remove the pass (this is not required) and the unneeded blank line above?

Done. This will be visible once I push the changes to the existing PR.

…s.py

stefdworschak

LGTM

hebs87 added 4 commits October 27, 2020 21:35

Created update_hackathon URL and view with logic to conditionally all…

d006c9f

…ow selecting past date for start date

Added Edit button hackathon_card.html with modal warning for finished…

c82c709

… or in progress hackathons

Added datetime format to start and end date form fields to render cor…

9773511

…rectly in edit form

Added logic to conditionally render Edit or Create title in create-ev…

45194d7

…ent.html

stefdworschak approved these changes Oct 28, 2020

View reviewed changes

stefdworschak added the hacktoberfest-accepted Accepted PR during Hacktoberfest label Oct 28, 2020

hebs87 added 2 commits October 28, 2020 19:48

Made stylistic amends to code in hackathon/views.py and hackathon/url…

b15781e

…s.py

Merge branch 'master' into feature/admin-update-hackathon

fc36c38

stefdworschak approved these changes Oct 29, 2020

View reviewed changes

stefdworschak merged commit 24752b7 into Code-Institute-Community:master Oct 29, 2020

stefdworschak linked an issue Oct 29, 2020 that may be closed by this pull request

#A03. As Admin, I would like to update existing Hackathon events. #41

Closed

hebs87 deleted the feature/admin-update-hackathon branch November 5, 2020 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#A03. As Admin, I would like to update existing Hackathon events. #106

#A03. As Admin, I would like to update existing Hackathon events. #106

hebs87 commented Oct 27, 2020

stefdworschak left a comment

stefdworschak Oct 28, 2020

hebs87 Oct 28, 2020

stefdworschak Oct 28, 2020

hebs87 Oct 28, 2020

stefdworschak Oct 28, 2020

hebs87 Oct 28, 2020

stefdworschak Oct 28, 2020

hebs87 Oct 28, 2020

stefdworschak left a comment


		if request.method == 'GET':

		template = "hackathon/create-event.html"

		hackathon = get_object_or_404(Hackathon, pk=hackathon_id)

		if request.method == 'GET':

#A03. As Admin, I would like to update existing Hackathon events. #106

#A03. As Admin, I would like to update existing Hackathon events. #106

Conversation

hebs87 commented Oct 27, 2020

User Story ID:

Description of PR:

Tests:

Know bugs/errors:

Screenshots:

Does this introduce a breaking change

stefdworschak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefdworschak left a comment

Choose a reason for hiding this comment