#M06. As a User, I would like to see my account. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@aticodein this is looking great so far! Would you be able to provide a bit more context on the Pull Request comments?
Basically we want to try to provide as much as possible here. |
TravelTimN
requested changes
Oct 16, 2020
There was a problem hiding this comment.
@aticodein Thanks for your work on this so far! Great progress 👍
See comments below for some minor code adjustments, thanks!
TravelTimN
changed the title
|
Hi Tim,
I'll be back at my laptop tonight and take a look on these in details.
Thanks
…On Fri, 16 Oct 2020, 15:27 Tim Nelson, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@aticodein <https://github.com/aticodein> Thanks for your work on this so
far! Great progress 👍
See comments below for some minor code adjustments, thanks!
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
> @@ -6,4 +6,23 @@
<!-- TO DO : build profile page -->
TEST PROFILE PAGE
+<!DOCTYPE html>
+ <h1>Profile Page</h1>
+ <h2>You are logged in as</h2>
+
+<!---------------------------------------profile display------------------------------------------------->
@aticodein <https://github.com/aticodein> please stick to standard HTML
comments, only using two dashes.
<!-- profile display -->
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
> @@ -6,4 +6,23 @@
<!-- TO DO : build profile page -->
TEST PROFILE PAGE
+<!DOCTYPE html>
+ <h1>Profile Page</h1>
+ <h2>You are logged in as</h2>
+
+<!---------------------------------------profile display------------------------------------------------->
+ <div class="container-fluid">
+ <div class="row">
+ <div class="col-md-4"><h4>Username :</h4><p> {{ user.username }} </p></div>
@aticodein <https://github.com/aticodein>
Since these lines will eventually grow to more content or design/styles,
let's try to break them up with some code formatting, instead of using
everything on a single-line. Something like this, for example:
<div class="col-md-4">
<h4>Username:</h4>
<p>{{ user.username }}</p>
</div>
The same would apply to the other lines below.
Also, watch out for extra spaces where they're not needed.
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
> {% endblock %}
+
+
Files should generally only have a single empty line at the end of the
file.
Can you remember the extra blank lines here, so there's only 1 blank line
at the end of the file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#69 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKXK2GQKAU6U7GCEKHNVTKDSLBJ4TANCNFSM4STKUQKA>
.
|
|
Changed the link in navbar>my profile to correct link from urls.py. |
TravelTimN
changed the title
TravelTimN
requested changes
Oct 17, 2020
There was a problem hiding this comment.
@aticodein
Thanks for those changes!
Just some extra spaces in and minor corrections, outlined below.
|
Thank you Tim,
I will do these changes tonight, unfortunately working this evening again
with no laptop.
Kind Regards,
Attila
…On Sat, 17 Oct 2020 at 18:06, Tim Nelson ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@aticodein <https://github.com/aticodein>
Thanks for those changes!
Just some extra spaces in and minor corrections, outlined below.
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
>
+<!-- Profile display -->
+
+ <div class="container-fluid">
+ <div class="row">
+
+ <div class="col-md-4">
+ <h4>Username :</h4>
@aticodein <https://github.com/aticodein>
Would you mind fixing some of the extra spaces on the code?
<h4>Username:</h4>
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
>
+<!-- Profile display -->
+
+ <div class="container-fluid">
+ <div class="row">
+
+ <div class="col-md-4">
+ <h4>Username :</h4>
+ <p> {{ user.username }} </p>
<p>{{ user.username }}</p>
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
>
+<!-- Profile display -->
+
+ <div class="container-fluid">
+ <div class="row">
+
+ <div class="col-md-4">
+ <h4>Username :</h4>
+ <p> {{ user.username }} </p>
+ </div>
+
+ <div class="col-md-4">
+ <h4>User e-mail address :</h4>
<h4>Email Address:</h4>
Short and sweet - just Email Address is fine.
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
>
+<!-- Profile display -->
+
+ <div class="container-fluid">
+ <div class="row">
+
+ <div class="col-md-4">
+ <h4>Username :</h4>
+ <p> {{ user.username }} </p>
+ </div>
+
+ <div class="col-md-4">
+ <h4>User e-mail address :</h4>
+ <p> {{ user.email }} </p>
<p>{{ user.email }}</p>
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
> + <div class="col-md-4">
+ <h4>Username :</h4>
+ <p> {{ user.username }} </p>
+ </div>
+
+ <div class="col-md-4">
+ <h4>User e-mail address :</h4>
+ <p> {{ user.email }} </p>
+ </div>
+
+ </div>
+
+ <div class="row">
+
+ <div class="col-md-4">
+ <h4>First name :</h4>
<h4>First Name:</h4>
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
> + <h4>Username :</h4>
+ <p> {{ user.username }} </p>
+ </div>
+
+ <div class="col-md-4">
+ <h4>User e-mail address :</h4>
+ <p> {{ user.email }} </p>
+ </div>
+
+ </div>
+
+ <div class="row">
+
+ <div class="col-md-4">
+ <h4>First name :</h4>
+ <p> {{ user.first_name }}</p>
<p>{{ user.first_name }}</p>
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
> + <div class="col-md-4">
+ <h4>User e-mail address :</h4>
+ <p> {{ user.email }} </p>
+ </div>
+
+ </div>
+
+ <div class="row">
+
+ <div class="col-md-4">
+ <h4>First name :</h4>
+ <p> {{ user.first_name }}</p>
+ </div>
+
+ <div class="col-md-4">
+ <h4>Last name :</h4>
<h4>Last Name:</h4>
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
> + <h4>User e-mail address :</h4>
+ <p> {{ user.email }} </p>
+ </div>
+
+ </div>
+
+ <div class="row">
+
+ <div class="col-md-4">
+ <h4>First name :</h4>
+ <p> {{ user.first_name }}</p>
+ </div>
+
+ <div class="col-md-4">
+ <h4>Last name :</h4>
+ <p> {{ user.last_name }}</p>
<p>{{ user.last_name }}</p>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#69 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKXK2GULI5RTTWUCU4MCALTSLHFKDANCNFSM4STKUQKA>
.
|
stefdworschak
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
LGTM
@aticodein could you just resolve the one small comment and we're good to go to merge the PR! Well, done btw!
|
Yes done |
|
Hi, I did remove the doctype tag, and request a new review.
Attila
…On Mon, 19 Oct 2020, 09:52 Stefan Dworschak, ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
@aticodein <https://github.com/aticodein> could you just resolve the one
small comment and we're good to go to merge the PR! Well, done btw!
------------------------------
In profiles/templates/profiles/profile.html
<#69 (comment)>
:
> @@ -3,7 +3,40 @@
{% block content %}
- <!-- TO DO : build profile page -->
- TEST PROFILE PAGE
+<!DOCTYPE html>
Could you please remove the unneeded doctype?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#69 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKXK2GVCNS4FZN44DJ42FOTSLP443ANCNFSM4STKUQKA>
.
|
TravelTimN
added
hacktoberfest
|
Thank you guys!
You just made my day.
This is a very big step for me.
Kind Regards
Attila
…On Mon, 19 Oct 2020, 13:20 Tim Nelson, ***@***.***> wrote:
Assigned #69
<#69> to
@aticodein <https://github.com/aticodein>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKXK2GULXJLUZMIHDXYWGTLSLQVHPANCNFSM4STKUQKA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the pull request