-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#P09 As a participant - I would like to submit my entry. #87
#P09 As a participant - I would like to submit my entry. #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
A few minor adjustments outlined below! 🦗
@ClaireLally8 sorry, I did not want to pile on and be the 3rd person to review your pull request, but since we were talking about your PR a bit I would be amiss not to review it for you!! Also, only for a few minor things I think it looks really good! 🥇 |
Thanks y'all @stefdworschak @TravelTimN @Eventyret I guess I'll fix these at some stage today ;) (but please, be perfectionists, I need to get better at the refining stuff!) |
If you don't approve this *shakes fist * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ClaireLally8 gonna approve this now since you are threatening me (yes, I am referring to the fist shaking lol). Please have a look at my final few comments and I will merge it when you revert back.
submission_time = models.DateTimeField(auto_now_add=True) | ||
speaker_name = models.CharField(default="", max_length=225) | ||
share_permission = models.BooleanField(default=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this here? Or more specifically can the person submitting the project legally agree to the sharing permissions for all team members? I would say we put something in the T&Cs when signing up that they need to confirm that any work that is produced as part of participating on this platform can be shared. @TravelTimN what do you think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah @TravelTimN
@ClaireLally8 @TravelTimN I am going to merge this now and will create a follow up issue for ourselves to decide this. |
Description
Creates the app for the submissions of completed hackathon project. Utilises the HackProject model and is filled out with a form by the users.
Pull request type
Testing
Manual testing by checking it functions.
Automated testing - * crickets *
Additional Information
Will need the templates edited as these are not finalised. Found within the submissions/templates/submissions folder :)
Does this introduce a breaking change