Additional PR in relation to User authentication ~ #83 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conversion to KeyError log, also linked nav Accountlinks and included if else check for user authenticated or otherwise
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the exception specific catch and logs that error using Django
logging. Also, the Navbar has been altered to check for User Authentication whether logged in or otherwise and depending on same shows a different set of dropdown nav-items under theMy Accountmain nav-item.Related Issue
#M00. As a User, I would like to register an account. - Auxfuse #83 <--- This is an already merged PR with this PR coming in based off additional requirements outlayed in the comments of the previous merge.
Testing
Exception testing not completed, however documentation was followed to ensure consistent normal code flow adherance.
In terms of the navigation, the Navbar state was tested per User Authentication state:
So if User is not Logged in:
RegisterandLoginAnd if User is already Logged in:
My ProfileandLogoutSee gif depicting Navbar before login, and navbar after login....also quick frame inclusion of the register page returning the signup template.
Does this introduce a breaking change