#S06/#S09 As Staff I would like to enroll/withdraw as a Judge #90
Conversation
Added basic view and connected it to ListView.
Includes logic to display judges and the option to enroll.
Does not process any data yet, simply proof of concept.
Merge with original fork
Toast popup function is reformatted. Fetch now catches errors
This should now fix issues #S09 - Code-Institute-Community#38 and #S06 - Code-Institute-Community#35
The first "Unenroll" click wouldn't change because of whitespace.
There was a problem hiding this comment.
@Ri-Dearg overall a very nice change. Just consider moving from AJAX to just submitting the form; unless there is a specific reason for it that I missed.
| {% block js %} | ||
| {{ block.super }} | ||
| {% if request.user.is_staff %} | ||
| <script> |
There was a problem hiding this comment.
Could you extract the JS content to an external file please?
There was a problem hiding this comment.
Also, why have you gone with an AJAX approach here instead of just submitting the form and redirecting back to the updated page? Since we are using Django I find this a bit counter intuitive.
There was a problem hiding this comment.
Okay, cool. I'll outline my AJAX reasoning below and you make the call.
Will I move it to the main script.js or will I create a different one? I wasn't sure where it would be more appropriate so I used the block js.
I went with AJAX because it's easy and fast. Some buttons do pretty much the same thing, only adding/removing info from the database, so it's simpler. In other user stories, like "enroll/withdraw as a participant", it would be easy to add another button on the page that would function similarly, using the same scripts. Some users would have two buttons. This way it's more like clickable options in front of you, instead of sending numerous forms. I think it's nice.
From a user perspective, it's a smoother, more responsive experience. The less required page loading, the better, no? A page-load makes sense for detailed forms or new content, but it's a small update and doesn't provide the user with any new content or info. So, I thought "why reload the whole page?". I got a lot of feedback on my final milestone about users not wanting to stay on sites with page-reloads that don't provide new content or engagement and I ended up using a lot of ajax. In summary, I thought it was a useful addition for UX.
I'm wondering why is it counter-intuitive with Django?
If you think it's better without it, I'll take it out, still, it would be useful for me to learn.
Also, I've realised I need to add code to prevent users from signing up to Hackathons past their end date, so I have to do that too before I've finished.
There was a problem hiding this comment.
@Ri-Dearg okay fair enough. It is a bit counter intuitive for me, but I can see your point and thinke we can keep the AJAX logic then. In terms of the external JS. I'd just add it to script.js since we don't really have any JS at the moment it should be fine.
|
@Ri-Dearg I think there are a few merge conflicts now. Please resolve them and revert back to me so I can merge this before it goes stale. Thanks! |
|
Hi Stefan, sorry, I haven't been able to work on this. I've gotten quite sick with flu symptoms and haven't been able to concentrate. I'll get back to it as soon as I'm able. |
|
@Ri-Dearg no problems at all! Your health is much more important. Please take care and I hope you feel better soon! |
|
Hi @stefdworschak, If you think it would be better that I tidy it up and push anyway, I can get that done tomorrow. |
@stefdworschak |
|
Closing PR as covered by #113 |
Description
Pull request type
Related Issue
#35
#38
Testing
Screenshots
Logged In as Staff
Not Staff
Additional Information
messages.htmlandbase.htmlhave been edited to accommodate the toast pop-ups. I have pulled the most recent version to make sure I am not changing anything already present.style.cssDoes this introduce a breaking change