#P03. As Participant, I would like to update my profile. #98
Conversation
Add EditProfileForm in forms.py. Create edit_profile view and urls. Create edit_profile.html. Add an Edit Profile button on profile.htm.
There was a problem hiding this comment.
@natalijabujevic0708 looking very good, there are just a few minor comments from me. Overall there are also two extra things that I would like you to look at as part of this PR.
- Adding user_type and current_lms_module to the profile view
- Applying some better styling to the edit profile form
| <div class="container"> | ||
| <form method="post" enctype="multipart/form-data"> | ||
| {% csrf_token %} | ||
| <table> |
There was a problem hiding this comment.
Why did you add a table here? I don't think that's needed.
|
|
||
| {% block content %} | ||
| <h1>Edit Profile</h1> | ||
| <div class="container"> |
There was a problem hiding this comment.
The base template already has an element with a container class, so I would remove this div.
| if request.method == 'POST': | ||
| form = EditProfileForm(request.POST, instance=request.user) | ||
|
|
||
| if form.is_valid(): |
There was a problem hiding this comment.
I think you need to add another else here for when form.is_valid() is not True.
accounts/views.py
Outdated
| return redirect('profile') | ||
| else: | ||
| form = EditProfileForm(instance=request.user) | ||
| contex = { |
There was a problem hiding this comment.
I think you mispelt context here, but I would just pass the dict directly into render.
accounts/forms.py
Outdated
| 'first_name', | ||
| 'last_name', | ||
| 'slack_display_name', | ||
| 'user_type', |
There was a problem hiding this comment.
Could you please remove this field? I don't think the user should be able to change this. Instead a change in user_type should come from an admin.
|
@stefdworschak I made the changes, let me know if everything is ok or I should change something :) |
There was a problem hiding this comment.
LGTM
@natalijabujevic0708 we merged some more changes and it seems there is a merge conflict now, could you just resolve that and let me know once it's done so I can merge the PR?
|
@stefdworschak done :) |
Description
The users can edit their profile details:
Pull request type
Testing
All testing was done manually and the profile was successfully edited and updated.
Screenshots
2.Edit Profile
Additional Information
There is one field missing on the edit profile page:
Shipping Address
I am planning to add it in the future as currently I don't know how to implement the condition enabled only if part of a winning team
Does this introduce a breaking change