Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weather feature #51

Merged
merged 15 commits into from
Jun 17, 2022
Merged

weather feature #51

merged 15 commits into from
Jun 17, 2022

Conversation

chrisdedman
Copy link
Collaborator

@chrisdedman chrisdedman commented Jun 13, 2022 •
edited

Get the current weather from any city in the world. Weather includes condition, temperature, Pressure Atmospheric, Visibility, Humidity

PenguinBoi12
PenguinBoi12 requested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@PenguinBoi12 PenguinBoi12 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend a little bit more separation of logic. What I mean by that, is that you shouldn't put everything in the same function. You can separate the logic for getting the weather, getting the time for the city, some specific calculation, etc.

bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
@PenguinBoi12 PenguinBoi12 self-assigned this Jun 13, 2022
@PenguinBoi12 PenguinBoi12 added the change needed Indicate that the PR need change before merging label Jun 13, 2022
@chrisdedman
edited
d9d1c4c 
Edited based on the current comment
PenguinBoi12
PenguinBoi12 requested changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@PenguinBoi12 PenguinBoi12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job that's a big improvement, keep it up

bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
PenguinBoi12
PenguinBoi12 reviewed Jun 14, 2022
View reviewed changes
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
PenguinBoi12
PenguinBoi12 requested changes Jun 16, 2022
View reviewed changes
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
bot/extensions/fun/weather.py Outdated Show resolved Hide resolved
PenguinBoi12
PenguinBoi12 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@PenguinBoi12 PenguinBoi12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go that's seems pretty good. It's not the most perfect thing, in real life we could abstract everything even more but that's great like that. I'm going to think about the api key thing.

@PenguinBoi12 PenguinBoi12 merged commit 2829abb into Code-Society-Lab:main Jun 17, 2022
@chrisdedman chrisdedman deleted the patch-1 branch January 22, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoyBison SoyBison SoyBison left review comments

@PenguinBoi12 PenguinBoi12 PenguinBoi12 approved these changes

Assignees

@PenguinBoi12 PenguinBoi12

Labels
change needed Indicate that the PR need change before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisdedman @SoyBison @PenguinBoi12