Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to allow the space character to show as ␣ #171

Merged
merged 2 commits into from Mar 31, 2019

Conversation

8176135
Copy link
Contributor

@8176135 8176135 commented Nov 27, 2017

For this issue: #165
I added an checkbox with all the other options under Appearance, which when checked will display spaces as ␣, not too sure what to call that character though.

First time contributing, so tell me if I did something wrong :)

Fixes #165
Fixes #198

@hnrkndrssn hnrkndrssn self-assigned this Mar 31, 2019
@hnrkndrssn hnrkndrssn added this to the 2.3.0 milestone Mar 31, 2019
@hnrkndrssn hnrkndrssn merged commit 982f350 into Code52:master Mar 31, 2019
@hnrkndrssn
Copy link
Contributor

Thank you very much @Hand-of-Cthulhu, I made a couple of small aesthetic changes to the UI in regards to the placement of the checkbox but other than that this was all good.

Also, I learned today that the character is unicode and it's name is open box :)

One thing I'd mention is that if you're fixing an existing issue you can put Fixes #IssueNumber in your PR and that issue will be closed automatically when your PR is merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants