Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered Processes #177

Merged
merged 3 commits into from Apr 16, 2019
Merged

Filtered Processes #177

merged 3 commits into from Apr 16, 2019

Conversation

eajhnsn1
Copy link
Contributor

Use Case

When doing a presentation, I really only want key presses to be shown if they are for specific applications, such as Visual Studio or another text editor. This will prevent passwords and other secrets from accidentally being shown as they are typed into other applications.

Proposed Solution

Add an option to the settings to allow a regular expression filter for process names to whitelist key presses from. If no filter, or an invalid regular expression is supplied, Carnac should behave as if unfiltered (ie. today's current behavior).

Notes

This is my first pull request in any repo, and I'm new to git. If this isn't the correct process or procedure, I apologize. If I should have done anything different, just let me know and I will correct it.

Thanks!

@hnrkndrssn hnrkndrssn self-assigned this Mar 31, 2019
@hnrkndrssn hnrkndrssn added this to the 2.3.0 milestone Mar 31, 2019
@hnrkndrssn hnrkndrssn merged commit 952bf05 into Code52:master Apr 16, 2019
@hnrkndrssn hnrkndrssn modified the milestones: 2.3.2, 2.3.3 Apr 18, 2019
@hnrkndrssn
Copy link
Contributor

@eajhnsn1 thank you for your PR and my apologies that it took so long to get it merged and shipped!

@eajhnsn1
Copy link
Contributor Author

Thanks for accepting!

@eajhnsn1 eajhnsn1 deleted the filtered-processes branch April 19, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants