Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Added missing next and previous items in the page Hash in the Liquid engine #271

Merged
merged 3 commits into from Nov 6, 2015
Merged

Added missing next and previous items in the page Hash in the Liquid engine #271

merged 3 commits into from Nov 6, 2015

Conversation

k94ll13nn3
Copy link

While browsing the files generated by pretzel create I noticed that, after adding a new post, there were no previous and next link at the bottom of the page while the layout contained them.

This small change made those links appeared in the demo site from pretzel create when multiple posts are present.

I don't know if it is the right place for the change, and I didn't make tests since the Razor counterpart, which already worked, does not seem to have any.

@laedit
Copy link
Member

laedit commented Oct 28, 2015

Thanks a lot, that was bothering me for a while but I haven't the time to fix it.
Could you just add one or two tests?

@k94ll13nn3
Copy link
Author

I added some tests, I hope they are enough and fit the project guidelines.

I had a question: when I am on the most recent post, I am expecting to have a "previous" link but here it is a "next" link since the next page is the page older than the current page. Is it an expected behavior ?

@laedit
Copy link
Member

laedit commented Oct 29, 2015

Thanks.
It's surprising, but I don't know if it's on purpose.

@JakeGinnivan, @shiftkey do you know if it's the expected behavior?

@laedit
Copy link
Member

laedit commented Nov 5, 2015

So without response, I propose to change the current behavior:
@k94ll13nn3 since you are already on the subject, could you inverse the content of GetNext and GetPrevious methods in JekyllENgineBase?
This way we will have a more coherent result.

@k94ll13nn3
Copy link
Author

Done.

@laedit
Copy link
Member

laedit commented Nov 6, 2015

You are awesome, thanks!

laedit pushed a commit that referenced this pull request Nov 6, 2015
Added missing next and previous items in the page Hash in the Liquid engine
@laedit laedit merged commit 470d672 into Code52:master Nov 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants