Refactor mint() of AssetScheme to createMintTransaction()

CodeChain-io · Jul 19, 2018 · d0c467a · d0c467a
1 parent 53cab11
commit d0c467a
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/API.md b/API.md
@@ -118,7 +118,7 @@ In this example, we want to create an asset called "Gold". Thus, we define a new
 ```
 After Gold has been defined in the scheme, the amount that is minted but belong to someone initially. In this example, we create 10000 gold for Alice.
 ```javascript
-    const mintTx = goldAssetScheme.mint(aliceAddress);
+    const mintTx = goldAssetScheme.createMintTransaction({ recipient: aliceAddress });
 ```
 Then, the AssetMintTransaction is processed with the following code:
 ```javascript

diff --git a/examples/mint-and-transfer.js b/examples/mint-and-transfer.js
@@ -33,7 +33,7 @@ async function sendTransaction(tx) {
         registrar: null,
     })
 
-    const mintTx = goldAssetScheme.mint(aliceAddress);
+    const mintTx = goldAssetScheme.createMintTransaction({ recipient: aliceAddress });
 
     await sendTransaction(mintTx);
     const mintTxInvoice = await sdk.rpc.chain.getTransactionInvoice(mintTx.hash(), 5 * 60 * 1000);

diff --git a/integration_tests/Rpc.spec.ts b/integration_tests/Rpc.spec.ts
@@ -105,7 +105,7 @@ describe("rpc", () => {
                     metadata: "metadata",
                     amount: 10,
                     registrar: null
-                }).mint(await sdk.key.createPubKeyAddress());
+                }).createMintTransaction({ recipient: await sdk.key.createPubKeyAddress() });
                 const parcel = sdk.core.createChangeShardStateParcel({
                     transactions: [mintTransaction],
                 });

diff --git a/integration_tests/Transaction.spec.ts b/integration_tests/Transaction.spec.ts
@@ -42,7 +42,7 @@ test("AssetTransferTransaction fromJSON", async () => {
         metadata: "metadata of non-permissioned asset",
         amount: 100,
         registrar: null,
-    }).mint(addressA);
+    }).createMintTransaction({ recipient: addressA });
     await sendTransactions({ transactions: [mintTx] });
     const firstAsset = await sdk.rpc.chain.getAsset(mintTx.hash(), 0);
 

diff --git a/integration_tests/helper.ts b/integration_tests/helper.ts
@@ -24,7 +24,7 @@ export const sendTransactions = async ({ transactions }) => {
 export const mintAsset = async ({ metadata, amount, lockScriptHash, registrar }) => {
     const assetScheme = sdk.core.createAssetScheme({ metadata, amount, registrar });
     const assetAddress = sdk.key.classes.AssetTransferAddress.fromLockScriptHash(lockScriptHash);
-    const assetMintTransaction = assetScheme.mint(assetAddress);
+    const assetMintTransaction = assetScheme.createMintTransaction({ recipient: assetAddress });
     return {
         ...await sendTransactions({ transactions: [assetMintTransaction] }),
         assetMintTransaction

diff --git a/src/core/AssetScheme.ts b/src/core/AssetScheme.ts
@@ -40,15 +40,15 @@ export class AssetScheme {
         };
     }
 
-    mint(address: AssetTransferAddress, options: { nonce?: number } = {}): AssetMintTransaction {
-        const { nonce = 0 } = options;
+    createMintTransaction(params: { recipient: AssetTransferAddress, nonce?: number }): AssetMintTransaction {
+        const { recipient, nonce = 0 } = params;
         const { networkId, metadata, amount, registrar } = this;
         return new AssetMintTransaction({
             networkId,
             metadata,
             output: {
                 amount,
-                ...address.getLockScriptHashAndParameters(),
+                ...recipient.getLockScriptHashAndParameters(),
             },
             registrar,
             nonce,

diff --git a/src/key/index.ts b/src/key/index.ts
@@ -30,7 +30,7 @@ export class Key {
 
     /**
      * Creates AssetTransferAddress for non-standard P2PK asset.
-     * To use this address AssetScheme.mint() or Asset.transfer().
+     * To use this address AssetScheme.createMintTransaction() or Asset.transfer().
      * @returns AssetTransferAddress
      */
     createPubKeyAddress(): Promise<AssetTransferAddress> {
@@ -39,7 +39,7 @@ export class Key {
 
     /**
      * Creates AssetTransferAddress for the standard P2PKH asset.
-     * To use this address, see AssetScheme.mint() or Asset.transfer().
+     * To use this address, see AssetScheme.createMintTransaction() or Asset.transfer().
      * @returns AssetTransferAddress
      */
     createPubKeyHashAddress(): Promise<AssetTransferAddress> {