Fully implement stakeholder features #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joojis
reviewed
Apr 11, 2019
package.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "codechain-stakeholder-sdk", | |||
There was a problem hiding this comment.
You shouldn't change this field because -js postfix is redundant when it comes to the NPM package.
foriequal0
force-pushed
the
feature/full-impl
branch
from
749cb63
to
db57eb4
Compare
Merged
foriequal0
force-pushed
the
feature/full-impl
branch
3 times, most recently
from
f0ffc4e
to
b58ff42
Compare
joojis
reviewed
Apr 15, 2019
src/index.ts
Outdated
|
|
||
| export function createDelegateCCSTransaction( | ||
| sdk: SDK, | ||
| delegator: PlatformAddressValue, |
There was a problem hiding this comment.
Doesn't it have to be a delegatee?
joojis
reviewed
Apr 15, 2019
src/index.ts
Outdated
|
|
||
| export function createRequestRevokeTransaction( | ||
| sdk: SDK, | ||
| delegator: PlatformAddressValue, |
foriequal0
force-pushed
the
feature/full-impl
branch
from
b58ff42
to
5521508
Compare
foriequal0
force-pushed
the
feature/full-impl
branch
from
5521508
to
c267c0f
Compare
joojis
reviewed
Apr 16, 2019
README.md
Outdated
| }); | ||
| ``` | ||
|
|
||
| ### Request to revoke a delegated stake tokens |
There was a problem hiding this comment.
Is the article a necessary? I'm not sure about it
There was a problem hiding this comment.
I'll fix them and merge this PR.
foriequal0
force-pushed
the
feature/full-impl
branch
from
c267c0f
to
efda55b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1