Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ICS 04 Channel & Packet #197

Closed
5 tasks done
junha1 opened this issue Feb 21, 2020 · 0 comments
Closed
5 tasks done

Implement ICS 04 Channel & Packet #197

junha1 opened this issue Feb 21, 2020 · 0 comments
Assignees
Labels
experiment Experimental features ics Interchain standard

Comments

@junha1
Copy link
Contributor

junha1 commented Feb 21, 2020

  • Implement core types and en/decoding
  • Implement channel
  • Implement packet
  • Add transaction handler and datagram types
  • Implement related RPCs

Datagrams

Mostly corresponded with required functions

  • ChanOpenInit
  • ChanOpenTry
  • ChanOpenAck
  • ChanOpenConfirm
  • ChanCloseInit
  • ChanCloseConfirm
  • SendPacket
  • RecvPacket
  • AcknowledgePacket

These will not be implemented in PoC

  • TimeoutPcaket
  • TimeoutOnClose
  • ClenupPacket

RPCs

  • query_channel_end()
  • query_packet_commitment()
  • query_packet_acknowledgement()
  • query_next_sequence_recv()
  • query_latest_send_packet()
  • query_latest_recv_packet()

Questions

  • Why no port & channel here? emitLogEntry("sendPacket", {sequence: packet.sequence, data: packet.data, timeout: packet.timeout})

Changes

  • We always require acknowledgement in recv_packet() since we don't know the use case of non-ack.
@junha1 junha1 added the ics Interchain standard label Feb 21, 2020
@junha1 junha1 self-assigned this Feb 21, 2020
@majecty majecty mentioned this issue Feb 21, 2020
11 tasks
@junha1 junha1 added the experiment Experimental features label Feb 27, 2020
@junha1 junha1 closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment Experimental features ics Interchain standard
Projects
None yet
Development

No branches or pull requests

1 participant