pt-BR scratch blocks error

[freyjaodds]

Practically all the scratch blocks in the new pt-BR projects are red, but the translations seem to be correct according to the scratch translation tool. I thought perhaps it's because these are the first pt-BR projects and that all of the blocks are turning out red, but then I found a couple that appear in Rock Band in the right colour so that's not the case. I guess @andylolz will take a one quick look at this and tell me the obvious error as usual :) No pressure though!

http://scratchblocks.codeclub.org.uk/translator/#script=when%20flag%20clicked%0A%09%09forever%0A%09%09%09hide%0A%09%09%09wait%20(1)%20secs%0A%09%09%09show%0A%09%09%09wait%20(1)%20secs%0A%09%09end&from=en&to=pt_BR

[freyjaodds]

FYI @lgmoneda

[andylolz]

I’m not sure… But I suspect the language in the project frontmatter needs to be set to pt_BR rather than the current pt-BR. So an underscore rather than a hyphen. I’ll test that out now to check.

UPDATE: Yeppers – ^^ it’s this ^^

[martinpeck]

That sounds wrong. Locales use hyphens, not underscores.
Why is pr_BR considered correct here?

[andylolz]

Locales use hyphens, not underscores.

ISO 15897 and BCP 47 seem to disagree with one another on this point.

Why is pr_BR considered correct here?

It comes from the language segment of the URLs used here:
http://translate.scratch.mit.edu

e.g.:
http://translate.scratch.mit.edu/pt_BR/

Scratchblocks adheres to the same standard:
https://github.com/tjvr/scratchblocks/blob/master/src/build_translations.py#L16-L24

…so it has propagated from there.

[martinpeck]

So, which project front matter do you think needs updating?
All of our current project front matter has hyphens, not underscores.
Perhaps I'm missing something.

[andylolz]

All of our current project front matter has hyphens, not underscores.

Yes. In most cases you get away with it, because of this horrible indexOf hack used here:
https://github.com/CodeClub/pandoc_scratchblocks/blob/master/scratch_template.html#L42

Another option would be to add another hack to this template, to substitute underscores for hyphens (see RaspberryPiFoundation/pandoc_scratchblocks#10.)

The least hacky solution might be to add a scratch_language_code to each of the language files here:
https://github.com/CodeClub/lesson_format/tree/master/assets/languages
…and then send that through to pandoc_scratchblocks.

[martinpeck]

The specific example you mentioned above (Ghost Busters?) looks fixed, as do many other scratch block instances:

http://projects.codeclubworld.org/pt-BR/01_scratch_01/03/Ghostbusters.html

However, some are not:

http://projects.codeclubworld.org/pt-BR/01_scratch_01/04/ChatBot.html

[martinpeck]

Paint Box shows that it's only certain blocks that are being missed:
http://projects.codeclubworld.org/pt-BR/01_scratch_01/05/Paint%20Box.html

[andylolz]

Paint Box shows that it's only certain blocks that are being missed

This is a separate bug. It’s because this:
https://github.com/CodeClub/pandoc_scratchblocks/blob/master/scratchblocks2/translations-all.js

…doesn’t match this:
https://github.com/CodeClub/scratchblocks2/blob/gh-pages/translations-all.js

They probably both need updating.

[andylolz]

Merging the following should fix the problem:

• Update translations pandoc_scratchblocks#11
• Update language for pt-BR chatbot #402
• Remove pandoc_scratchblocks submodule lesson_format#182

As an alternative to the last of these, the submodule could just be updated.

Also, merging CodeClub/scratchblocks2#4 will update http://scratchblocks.codeclub.org.uk/translator/ so it’s in sync.

[andylolz]

Oops I didn’t mean to trigger this to close!

It should be fixed, but I guess lesson_format will need to be re-run for the changes to take effect.

[freyjaodds]

Not to worry, Rik and I are keeping an eye on it tomorrow and we will re-open if there's still an issue :) Thanks!

[andylolz]

This doesn’t seem to be fixed. The example @martinpeck posted above, for instance:
http://projects.codeclubworld.org/pt-BR/01_scratch_01/05/Paint%20Box.html

It works on scratchblocks translator, though. I think the current master of lesson_format should work, so I guess the version on heroku needs updating?

[freyjaodds]

@lgmoneda we believe this has been fixed now - I will check it tomorrow morning to make sure no red scratch blocks remain.

@andylolz thank you, you are a star!

[andylolz]

Nice one – looks fixed to me! 🍰