feat: improve lookup performance and allow composite key lookup #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edusperoni
force-pushed
the
feat/lookup-improvements
branch
from
5ffb72d
to
dfbc504
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1206 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 88 88
Lines 5776 5795 +19
Branches 489 494 +5
=======================================
+ Hits 5757 5776 +19
Misses 17 17
Partials 2 2
β View full report in Codecov by Sentry. |
edusperoni
force-pushed
the
feat/lookup-improvements
branch
from
dfbc504
to
bf16db1
Compare
Merged
|
This should probably be documented, that you can now directly look up composite keys. |
7 tasks
CodeDredd
added a commit
that referenced
this pull request
Sep 17, 2023
* fix(pinia-orm-1569): Wrong behaviour of `$getOriginal` (#1576) * fix(pinia-orm-1569): Wrong behaviour of `$getOriginal` * refactor(pinia-orm-1569): fix build error * refactor(pinia-orm-1569): fix test * refactor(pinia-orm-1569): add clearing closes #1576 * docs(pinia-orm-1382): Typo in docs examples: form -> from (#1590) closes #1382 * docs(pinia-orm): Broken link or missing reference (#1596) * docs(pinia-orm-1333): Broken link or missing reference * docs(pinia-orm): update note display * docs(pinia-orm): wrong closing closes #1333 * feat: Add options for uid, nanoid/uid and uuid/uid (#1510) * feat: uid options * feat: uid options - nanoid custom alphabet support * feat: uid options - update docs * feat: uid options - fix tests * refactor(pinia-orm): linting * refactor(pinia-orm): fix rules correctly * refactor(pinia-orm): Add better types & test coverage * refactor(pinia-orm): linting --------- closes #1509 Co-authored-by: Sergey Danilchenko <s.danilchenko@ttbooking.ru> Co-authored-by: Gregor Becker <gregor.becker@bpcs-consult.com> * feat: improve lookup performance and allow composite key lookup (#1206) * feat: improve lookup performance and allow composite key lookup * test(pinia-orm): add find composite key test closes #1205 --------- Co-authored-by: Gregor Becker <gregor@codedredd.de> Co-authored-by: Gregor Becker <gregor.becker@bpcs-consult.com> * chore(pinia-orm): linting * refactor(pinia-orm): `useRepo` was having the wrong types for repositories * refactor(pinia-orm): revert some type changes * feat: improve performance by mutating the state (#1604) * chore(deps): update devdependency @types/node to ^18.17.13 * chore(deps): update devdependency @types/node to ^18.17.13 * chore(deps): update devdependency @iconify/json to ^2.2.110 * chore: update sponsors * chore(deps): update all non-major dependencies * chore(deps): update devdependency @types/node to ^18.17.14 * chore(deps): update devdependency unplugin-icons to ^0.17.0 * chore(deps): update devdependency @typescript-eslint/parser to ^6.5.1-alpha.18 * chore(deps): update devdependency @typescript-eslint/parser to ^6.5.1-alpha.19 * chore(deps): update devdependency @typescript-eslint/parser to ^6.5.1-alpha.20 * chore(deps): update devdependency @typescript-eslint/parser to ^6.5.1-alpha.21 * chore(deps): update devdependency @iconify/json to ^2.2.111 * chore(deps): update devdependency @typescript-eslint/parser to ^6.5.1-alpha.22 * chore(deps): update actions/checkout action to v4 * chore(deps): update devdependency @typescript-eslint/parser to ^6.6.0 * feat: improve performance by mutating the state --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Gregor Becker <gregor@codedredd.de> * refactor(pinia-orm): Move away from js files and use cjs extension. Also some code refactorings. * refactor(pinia-orm): Add correct operation for `insert` * chore: Change renovate cycle * chore: Add pnpm default install strategy * feat(pinia-orm): Add namespace option for the store (#1618) * feat(pinia-orm-1437): Add namespace option for the store * refactor(pinia-orm): change build command & fix small typo * ci(pinia-orm): change build:ci to build * ci(pinia-orm): change ci build steps * ci(pinia-orm): add stub build * ci(pinia-orm): fix build stub command * ci(pinia-orm): fix build prepare command * ci(pinia-orm): fix other commands * ci(pinia-orm): change size command * refactor(pinia-orm): linting closes #1437 * docs: add Compositekey lookup (#1621) * fixed vuex orm typo in the docs * added docs for composite primary key lookups * fix(pinia-orm): `Uncaught TypeError: parent.$fields()[key] is undefied` when inserting nested data with polymorphic relationships (#1648) * fix(pinia-orm): `Uncaught TypeError: parent.$fields()[key] is undefined` when inserting nested data with polymorphic relationships * refactor(pinia-orm): linting * refactor(pinia-orm): remove comment closes #1635 * docs: Update depencies & fix small display errors (#1627) * docs: upgrade dependencies & improve styling * docs: fix search api & update index * docs: update yarn lock * feat: Add plugin system & axios plugin (#1603) * feat(axios): Create package * feat(axios): Create package * refactor(axios): update working axios plugin * feat(axios): add composables & axios repository * refactor(axios): make build work & correct typings * refactor(axios): update config * feat(pinia-orm): add plugins option * feat(pinia-orm): finish add plugin feature * test(axios): make tests work * refactor(pinia-orm): cleanup types * refactor(pinia-orm): linting * refactor(pinia-orm): fix build typings * refactor(pinia-orm): adjust size * refactor(axios): linting * test(axios): add test for extending repository * feat(axios): add first docs & add `define` function for plugins * docs(axios): continue writing * docs(axios): port more docs from vuex-orm axios * refactor(axios): linting * refactor(axios): vuex typos * docs: : Update correct size * docs: : Update nuxt dependencies * refactor(pinia-orm): Make nanoid async uuid deprecated * chore: Remove agolia workflow * chore: Use codecov v3 * feat(pinia-orm): Add `setModel` for Repository This is handy if you want to create a custom `useRepo` composable * refactor(pinia-orm): linting * feat(pinia-orm): Throw an error when trying to save a list into a one to one relationship (#1670) closes #1634 * docs(pinia-orm): adapt STI docs to be more correctly resolves #1629, resolves #1630, resolves #1631 * chore: Issue template improvement (#1636) * Added pinia-orm playground to reproduction links * Removed confusing Could this feature be implemented as a module in feature request template. It is from nuxt and doesn't make sense in the pinia-orm repo * Added playground suggestion to enviroment in bug report template and made it optional because somethings it is just not needed * feat(pinia-orm): Add HMR support resolves #1645 * chore: Change ci workflow for build * chore: Change ci workflow for build * chore: Change ci workflow for build * chore(nuxt): remove type module * chore: change ci build * feat(pinia-orm): Composite primary key can now be used with `destroy` and `onDelete` (#1671) resolves #1620 --------- Co-authored-by: Sergey Danilchenko <daniser@mail.ru> Co-authored-by: Sergey Danilchenko <s.danilchenko@ttbooking.ru> Co-authored-by: Eduardo Speroni <edusperoni@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: tintin10q <tintin10q@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1205
β Type of change
π Description
This PR speeds up lookup by doing direct lookups of specific target ids, as well as reduce the amount of unnecessary work by removing the already processed where call. As a side effect, it also allows for composite key lookup if passed as a string (
[key1,key2]).Some naive benchmarks of this: Adding 10000 entities into the store and then finding an entity by id 100 times took 1ms with this PR and 196ms with the current version.
Resolves #1205
π Checklist