Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"new" doesnt fire creating or created hook #801

Closed
Maqsyo opened this issue Jan 4, 2023 · 0 comments · Fixed by #808
Closed

"new" doesnt fire creating or created hook #801

Maqsyo opened this issue Jan 4, 2023 · 0 comments · Fixed by #808
Labels
bug Something isn't working

Comments

@Maqsyo
Copy link

Maqsyo commented Jan 4, 2023

Environment

  "dependencies": {
    "pinia": "2.0.28",
    "pinia-orm": "1.4.0",
    "vue": "3.2.45"
  },
  "devDependencies": {
    "@vue/cli-plugin-babel": "~4.5.0",
    "@vue/cli-plugin-eslint": "~4.5.0",
    "@vue/cli-service": "~4.5.0",
    "@vue/compiler-sfc": "^3.0.0-0",
    "babel-eslint": "^10.1.0",
    "eslint": "^6.7.2",
    "eslint-plugin-vue": "^7.0.0-0"
  },

Reproduction

https://codesandbox.io/s/young-cloud-odi2kr?file=/src/App.vue

Describe the bug

if calling new from repository the hooks for creatingand created not getting called.

Click on "console" and afterwards on the buttons. you will see, that "new" wouldnt trigger these hooks

Additional context

No response

Logs

No response

@CodeDredd CodeDredd added bug Something isn't working and removed pending triage labels Jan 5, 2023
CodeDredd added a commit that referenced this issue Jan 10, 2023
* fix(pinia-orm): `new` doesnt fire creating or created hook
closes #801

* refactor(pinia-orm): fix type

* refactor(pinia-orm): linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants