Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悶 When switching themes default text color is retained from old theme until reopening file #713

Closed
austincondiff opened this issue Aug 3, 2022 · 3 comments
Closed

馃悶 When switching themes default text color is retained from old theme until reopening file #713

austincondiff opened this issue Aug 3, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Aug 3, 2022 •
edited

Description

When a user switches to light theme from a dark theme some text remains dark until reopening file. The opposite is true as well.

To Reproduce

  1. Open Preferences > Themes.
  2. Change theme to opposite appearance (if currently light - dark, if currently dark - light).
  3. Notice how some text remains dark / light respectively.
  4. Close and reopen file.
  5. Notice how colors are now correct.

Expected behavior

Colors should all change immediately on theme change.

Version information

CodeEdit: 1.0
Hash: bb373d9
MacOS: 12.5 (21G72)
Xcode: 13.4.1 (13F100)
@austincondiff austincondiff added the bug Something isn't working label Aug 3, 2022
thecoolwinter added a commit to thecoolwinter/CodeEditSourceEditor that referenced this issue Aug 6, 2022
@thecoolwinter
Add .foregroundColor to default attributes
ba9caf8 
Adds the default text color to the default attributes applied to text in the editor. Fixes #713 in CodeEdit

CodeEditApp/CodeEdit#713
@thecoolwinter thecoolwinter mentioned this issue Aug 6, 2022
Merged
5 tasks
@thecoolwinter
Copy link
Collaborator

CodeEditTextView#48 should fix this! Ended up just needing to add the theme's base text color to the default attributes, everything was updating like it should so no need for a Coordinator or anything like that.

@austincondiff
Copy link
Collaborator Author

It鈥檚 much simpler than what we were originally thinking, that鈥檚 awesome! Glad you found out that鈥檚 all that was needed for this one!

@austincondiff
Copy link
Collaborator Author

Closing via CodeEditApp/CodeEditTextView#48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CodeEdit Project
Status: 馃弫 Complete
Milestone
No milestone
Development

No branches or pull requests
2 participants
@austincondiff @thecoolwinter