Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source control navigator history tab #1534

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Source control navigator history tab #1534

merged 5 commits into from
Jan 10, 2024

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Dec 27, 2023 •
edited

Description

Built out the Source Control navigator History tab where users can view the commit history on their current branch.

Related Issues

Checklist

  • Get commits in current branch
  • Add new History tab
  • Show commits from current branch in History tab
  • When commit is clicked display details page
  • Add commit header to commit details page
  • Get changed files for any given commit
  • Add list of changed files to commit details page
  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

image image
Screen.Recording.2023-12-27.at.3.47.13.PM.mp4

@austincondiff
Built out the Source Control navigator History tab where users can vi…
61a908e 
…ew the commit history on their current branch.
@austincondiff austincondiff changed the title Source Control navigator History tab Source control navigator history tab Dec 27, 2023
@austincondiff austincondiff added the enhancement New feature or request label Dec 27, 2023
@austincondiff austincondiff self-assigned this Dec 27, 2023
@austincondiff austincondiff linked an issue Dec 28, 2023 that may be closed by this pull request
✨ Source Control Navigator: History Tab #1528
Closed
4 tasks
@austincondiff austincondiff marked this pull request as draft December 30, 2023 16:11
@austincondiff austincondiff marked this pull request as ready for review January 8, 2024 22:52
thecoolwinter
thecoolwinter requested changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two things that need changes then good to go

CodeEdit/Features/NavigatorArea/SourceControlNavigator/History/Views/CommitListItemView.swift Show resolved Hide resolved
CodeEdit/Features/Git/Client/GitClient+CommitHistory.swift Outdated Show resolved Hide resolved
bombardier200
bombardier200 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@bombardier200 bombardier200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Starting to really get a good foundation for source control.

@austincondiff austincondiff merged commit 5b6eb0d into CodeEditApp:main Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombardier200 bombardier200 bombardier200 approved these changes

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@0xWDG 0xWDG Awaiting requested review from 0xWDG

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@EstebanBorai EstebanBorai Awaiting requested review from EstebanBorai

@Wouter01 Wouter01 Awaiting requested review from Wouter01

Assignees

@austincondiff austincondiff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@austincondiff @bombardier200 @thecoolwinter