Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic fuzzy search #1584

Conversation

activcoding
Copy link
Member

Description

This PR introduces a new fuzzy search algorithm that should deliver better results and better performance.
I've added the new algorithm to the open quickly overlay for now and not yet to the Settings. The reason is, the settings are a bit confusing as they are, the lack of documentation, confusing function and class names. I'm thinking of cleaning them up in a separate PR.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code
  • I've written some tests for the new functions

The other branch had weird merge conflicts so I was simpler to just make a new branch instead of fixing them.
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthijseikelenboom matthijseikelenboom merged commit a958a96 into CodeEditApp:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Fuzzy Search not working as expected
5 participants