Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recents list in Welcome window now refreshes after opening folders #1614

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

phlpsong
Copy link
Contributor

Description

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

screen-capture.webm

I also made some changes to the style of 'No Recent Project'. Please let me know if there are any issues.

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 12, 2024

Looks great, nice find! Can you post a screenshot of the "No Recent Projects" changes? We do have a CEContentUnavailableView you could probably use.

@phlpsong
Copy link
Contributor Author

Sure. I changed font and color here(commit)

Before change:
Screenshot 2024-03-12 at 22 15 31

Screenshot 2024-03-12 at 22 15 43

After change:

Screenshot 2024-03-12 at 22 15 02 Screenshot 2024-03-12 at 22 14 52

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@austincondiff austincondiff changed the title Recent projects list in Welcome window not refresh after open folders Recent projects list in Welcome window now refreshes after opening folders Mar 12, 2024
@austincondiff austincondiff changed the title Recent projects list in Welcome window now refreshes after opening folders Recents list in Welcome window now refreshes after opening folders Mar 12, 2024
@austincondiff austincondiff added the bug Something isn't working label Mar 12, 2024
@thecoolwinter thecoolwinter merged commit 6614949 into CodeEditApp:main Mar 12, 2024
2 checks passed
@thecoolwinter
Copy link
Collaborator

@allcontributors add @phlpsong for bug

Copy link
Contributor

@thecoolwinter

I've put up a pull request to add @phlpsong! 🎉

@phlpsong phlpsong deleted the recent-projects branch March 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Recent projects list in Welcome window not refresh after open folder
3 participants