Added font weight pickers to text editing and terminal settings #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…editing and terminal sections within settings. Small fix when using custom icons in editior tab.
austincondiff
requested review from
MarcoCarnevali,
FastestMolasses,
thecoolwinter,
Wouter01 and
activcoding
austincondiff
changed the title
FastestMolasses
previously approved these changes
Jun 14, 2024
activcoding
requested changes
Jun 15, 2024
CodeEdit/Features/Settings/Pages/TerminalSettings/TerminalSettingsView.swift
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/TextEditingSettings/Models/TextEditingSettings.swift
Outdated
Show resolved
Hide resolved
activcoding
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default font weight is now medium. Reduced the default line height from 1.45 to 1.2. Added font weight pickers to text editing and terminal sections within settings. Small fix when using custom icons in editor tab.
Related Issues
n/a
Checklist
Screenshots
Screen.Recording.2024-06-14.at.1.21.09.PM.mov