Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeEditUI: Added snapshot tests & Keep CircleCI? #482

Merged
merged 10 commits into from Apr 20, 2022

Conversation

lukepistrol
Copy link
Member

Description

Added snapshot tests for CodeEditUI components EffectView, FontPickerView, HelpButton & SegmentedControl

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

@lukepistrol lukepistrol marked this pull request as draft April 19, 2022 08:33
@lukepistrol
Copy link
Member Author

lukepistrol commented Apr 19, 2022

According to a google search CircleCI has some problems with rendering color correctly in snapshots.

Maybe because they use VMs and not dedicated machines. The snapshot tests run perfectly on our Mac mini runner as well as locally (did 1000 repetitions without a failure).

We might want to disable the test workflow on CircleCI temporarily (keep lint) until we figure out a way to run snapshot tests reliably.

We should be able to run snapshot tests.

Thoughts? @austincondiff @MarcoCarnevali @wdg @nanashili

pointfreeco/swift-snapshot-testing#313
pointfreeco/swift-snapshot-testing#419

# Conflicts:
#	CodeEdit/Info.plist
@lukepistrol lukepistrol added the clarification needed Further information is requested label Apr 19, 2022
@lukepistrol lukepistrol changed the title CodeEditUI: Added snapshot tests CodeEditUI: Added snapshot tests & Keep CircleCI? Apr 19, 2022
@0xWDG
Copy link
Collaborator

0xWDG commented Apr 19, 2022

Can we test in black and white for the snapshots?

@lukepistrol
Copy link
Member Author

lukepistrol commented Apr 19, 2022

Can we test in black and white for the snapshots?

Doesn't matter when the color is darker/brighter. It will still be different in greyscale.

Also it works on our Mac mini runner just fine without any problems and faster too!

@lukepistrol lukepistrol marked this pull request as ready for review April 20, 2022 12:17
@lukepistrol lukepistrol removed the clarification needed Further information is requested label Apr 20, 2022
@lukepistrol
Copy link
Member Author

I just had a conversation with @MarcoCarnevali and we decided that for now we will exclude the test action from CircleCI.

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austincondiff austincondiff enabled auto-merge (squash) April 20, 2022 13:05
@austincondiff austincondiff merged commit 3ea9536 into CodeEditApp:main Apr 20, 2022
@lukepistrol lukepistrol deleted the code-edit-ui-tests branch April 20, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants