[chore]: Pipelines for CI/CD #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukepistrol
requested review from
austincondiff,
matthijseikelenboom and
thecoolwinter
0xWDG
reviewed
Jan 4, 2023
only deploy on the main repo Co-authored-by: Wesley de Groot <email@wesleydegroot.nl>
thecoolwinter
requested changes
Jan 4, 2023
austincondiff
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all our actions get triggered by
on-pushoron-pull-requestevents and run in parallel. The problem with that is, that for example after pushing to themainbranch, if the tests were to fail, the pre-release would be deployed anyway.To mitigate this issue I implemented pipelines for both
on-pushevents onmainas well ason-pull-requestevents.on-push:SwiftLint->Tests->Deploy Pre-Releaseon-pull-request:SwiftLint->TestsNow if any job fails, no succeeding job will be run and the whole pipeline fails. Since we would not want to deploy a pre-release with a potential error.
Example
Update Dependencies
CodeEditTextViewto0.2.2