Support a text wrapping preference in the textview #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paque and hides configs that are immediately overridden.
lukepistrol
reviewed
Jan 6, 2023
|
linting issues noted. will address. |
…ts/CodeEditTextView into ben/text-wrapping-preference
|
Let's just wait for the review of @thecoolwinter |
thecoolwinter
approved these changes
Jan 10, 2023
|
@austincondiff , @lukepistrol - we should be all set to merge according to @thecoolwinter I have the follow-on changes ready for CodeEdit. |
|
I'll tag a new version in a couple of hours! |
|
I just tagged the new release with |
This was referenced Jan 12, 2023
Merged
matthijseikelenboom
added a commit
that referenced
this pull request
Jan 12, 2023
# Description This PR removes all references to `NSLayoutManager` and fixes syntax highlighting after the regression in #105. # Related Issues N/A # Checklist - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] I documented my code - [x] Review requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This addresses bug #84 , and fulfills some of the requirements of #66 (the rest of which will be implemented in CodeEdit in a nascent PR).
Technical Details
Two things to note:
This will likely regress highlighting behavior- more detailed discussion available on this discord channel, but TLDR: @thecoolwinter has plans to obviate the need for the removed
NSLayoutManagercode when he migrates that work to TextKit 2.I went ahead and removed the invocation of STTextView's static scrollableTextView() helper function. It sets a number of properties which are immediately overwritten by our code in
loadView(). It only obfuscates what's really happening here.