UndoManager Fixes #25
Merged
+84
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
requested review from
austincondiff,
matthijseikelenboom,
EstebanBorai and
activcoding
6 tasks
Sources/CodeEditTextView/TextLayoutManager/TextLayoutManager+Transaction.swift
Outdated
Show resolved
Hide resolved
austincondiff
previously approved these changes
Feb 29, 2024
activcoding
previously approved these changes
Feb 29, 2024
thecoolwinter
dismissed stale reviews from activcoding and austincondiff
via
28aa52b
austincondiff
approved these changes
Mar 1, 2024
thecoolwinter
added a commit
to CodeEditApp/CodeEditSourceEditor
that referenced
this pull request
Mar 1, 2024
### Description - Cleans up undo/redo operations when TextFormation is activated, for instance when inserting or deleting a newline. > ~Note: Requires [CodeEditTextView#25](CodeEditApp/CodeEditTextView#25) to be merged.~ Merged! ### Related Issues * closes #233 ### Checklist - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code ### Screenshots https://github.com/CodeEditApp/CodeEditSourceEditor/assets/35942988/d842b77d-60b4-4afd-be6c-2fb3d0342c4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
replaceCharacters. Fixes an issue where every edit was grouped, disabling the ability to undo individual operations. Future work will need to be done to enable grouping undo operations for multi-cursor operations.Newline + Whitespace(eg when making a newline and then inserting a tab). Also fixes the grouping order when deleting lines, so undoing a deleted line behaves as expected.Related Issues
Checklist
Screenshots
N/A