Map loader + Chart loader + sourceLink on chart container #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kilemensi looks good ? |
karimkawambwa
added a commit
to CodeForAfrica/Dominion.AFRICA
that referenced
this pull request
Aug 21, 2019
kilemensi
reviewed
Aug 21, 2019
There was a problem hiding this comment.
Looks and works great @karimkawambwa
- Code-wise, there is too much
{loading ? (
<ContentLoader
primaryOpacity={0.5}
secondaryOpacity={1}
>
>
<rect x="0" y="0" width="100%" height="100%" />
</ContentLoader>Customize it like you've done for TypographyLoader. e.g.
<BlockLoader loading={loading} {...props}>
{content to show when content is loaded}
</BlockLoader>
- Lets move sources to individual charts.
karimkawambwa
changed the title
There will be only one source link @kilemensi
|
|
@kilemensi I have addressed the code |
kilemensi
approved these changes
Aug 21, 2019
| <BlockLoader loading width="100%" height="100%" /> | ||
| </div> | ||
| )} | ||
| <div |
There was a problem hiding this comment.
This couldn't be a <BlockLoader ...><div ... /></BlockLoader>
There was a problem hiding this comment.
I didn't do this because of the root div.
Also because initial loading will look for div with mapId.
I will track this am make enhancement to the code later.
karimkawambwa
added a commit
to CodeForAfrica/Dominion.AFRICA
that referenced
this pull request
Aug 27, 2019
* Initial skeleton loader * Fix loader look * Profile tab loader * Search bar skeleton loader + all static text * Set is loading for chart container skeleton from hurumap-ui CodeForAfrica/HURUmap-UI#44 * Bump hurumap-ui version * Fix title grid * Fix chart factory to new hurumap-ui requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Video: https://recordit.co/8XI1wzJpDo
The gif below lost quality, not good representation.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: