Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps: Add formatter check to pr_checks_backend workflow #639

Closed
3 tasks
zackdreitzler opened this issue May 21, 2024 · 3 comments
Closed
3 tasks

DevOps: Add formatter check to pr_checks_backend workflow #639

zackdreitzler opened this issue May 21, 2024 · 3 comments
Labels

Comments

@zackdreitzler
Copy link
Collaborator

Describe the task

Add a formatter check to any PR impacting the data directory and its sub directories. This check ensures that new python code is formatted using the black formatter.

Acceptance Criteria

  • A format checking step exists on the pr_checks_backend workflow
  • When all files report as formatted, report a success to the PR that triggered this action
  • When one or more files report as not formatted, report a failure to the PR that triggered this action

Additional context

This story is currently blocked until #638 is completed.

@zackdreitzler zackdreitzler changed the title Task: Add formatter check to pr_checks_backend workflow DevOps: Add formatter check to pr_checks_backend workflow May 21, 2024
@nlebovits nlebovits removed the blocked label Jun 6, 2024
@Michael-Dratch
Copy link
Contributor

Can I pick up this task?

@nlebovits
Copy link
Collaborator

nlebovits commented Jul 17, 2024

@Michael-Dratch I actually double-dipped and folded this one into my PR #756. It should run build checks for both docker containers, a formatter check with black, and linting with flake8. Do you mind reviewing the PR?

@nlebovits
Copy link
Collaborator

closed by #756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants