Issue592 reword filter content #697
Conversation
|
@zheyichn is attempting to deploy a commit to the Clean and Green Philly Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -8,12 +8,14 @@ type ButtonGroupProps = { | |||
| options: string[]; | |||
| selectedKeys: string[]; | |||
| toggleDimension: (dimension: string) => void; | |||
| displayOptions?: { [key: string]: string }; | |||
There was a problem hiding this comment.
This is a good solution. It allows us to be flexible and change the button text without worrying about changing the button's value.
There was a problem hiding this comment.
@zheyichn the PR works as expected. That was a good, flexible solution that you came up with. As for Prettier, it looks like my code editor is formatting files the same way as yours. So I wouldn't worry too much about it for now. Thanks for your work!
|
@zheyichn I've added this line to your PR description: |
Prettierseems to do something differently then the existing formatter from main, many file changes are simply due to auto formatting, should I adjust myPrettiersetting to make formatting more consistent ? (If so, could you pls share yourPrettiersetting with me @CodeWritingCow thx!)Closes #592
owner-btn-local-test.mov