Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ref] Add model of School #121

Open
Rafalkufel opened this issue Jan 27, 2020 · 2 comments
Open

[ref] Add model of School #121

Rafalkufel opened this issue Jan 27, 2020 · 2 comments
Assignees

Comments

@Rafalkufel
Copy link
Contributor

Rafalkufel commented Jan 27, 2020

We need to store data of schools so we have to create model of School object.

Fields:

  1. id
  2. schoolName: string - full name of school
  3. schoolAddress: string - eg. Grywałd, ul. Konwaliowa 33,
  4. schoolPostcode: string - eg. 65-256 Poznań,
  5. schoolType: reference to schoolType,

We should disscuss what about school complex (polish Zespół Szkół eg. Zespół Szkół Budowlanych) which contains many different schools (eg Zasadnicza Szkoła Zawodowa or Technikum Budowlane). All that names should be included on the school description.

If you add fixtures to that model it'd be nice.

@agatakozinska
Copy link
Contributor

agatakozinska commented Jan 27, 2020

schoolPostcode I think we should divide this field into postal code and city, not just everything in one input and probably the same with schoolAddress ?
About complexity of school name, it seems, in that case, we don't need information that it's Zespół Szkół Budowlanych only the school a pupil attends because that is written in their ID (the same as a stamp) (https://www.portaloswiatowy.pl/dokumentacja-szkolna-przepisy-ogolne/stemplowanie-legitymacji-szkolnych-w-zespole-szkol-9113.html) , also for e.g. you have XXI Liceum Ogólnokształcące zostało otwarte (...) w budynku Zespołu Szkół Budownictwa Nr 1. it's treated as a building, not institute. Well, I'm not an expert about it, maybe you have better information.

@Maciek246 Maciek246 self-assigned this Feb 5, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Feb 12, 2020
@Rafalkufel
Copy link
Contributor Author

When it comes to school names. I think, that at this moment we can stay with just bare school name and omit name of complex of school. Later we can just ask people from supporting centers about thier practice.

Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Feb 13, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Feb 13, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Feb 13, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Feb 14, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Feb 14, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Feb 14, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Feb 14, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Feb 17, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Mar 4, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Mar 4, 2020
Maciek246 added a commit to Maciek246/alinka-electron that referenced this issue Mar 4, 2020
Rafalkufel added a commit that referenced this issue Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants