[lambda_api_ses] Added basic configuration for AWS Lambda + API Gateway + Role #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturtamborski
approved these changes
Aug 9, 2019
| # to deploy from this template: | ||
|
|
||
| "bucket" = | ||
| "key" = "terraform/Infrastructure/<name-of-environment>.tfstate" |
There was a problem hiding this comment.
Improvement: We could use terraform workspaces instead of hardcoding this
https://www.terraform.io/docs/state/workspaces.html
|
|
||
| provisioner "local-exec"{ | ||
| command = <<COMMAND | ||
| rm -rf ${data.archive_file.lambda_zip.output_path} |
There was a problem hiding this comment.
do we need -r for lambda.zip? It's just one file.
| @@ -0,0 +1,36 @@ | |||
| terraform { | |||
There was a problem hiding this comment.
Nitpick: This looks like tf 0.11 syntax which is OK but (as an improvement) we could use 0.12.
Though I'd also recommend using tfenv for pinning code to specific version of terraform which is not always backward compatible.
[1] https://github.com/tfutils/tfenv
|
I'm closing this one in favor of #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.