fix(http-function-runtime-v3): fix undeclared variable and added impr…

…ove tests for set-cookie (#534)
CodeGenieApp · Jul 26, 2022 · 34bd7da · 34bd7da
1 parent 2764c09
commit 34bd7da
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/__tests__/integration.js b/__tests__/integration.js
@@ -395,7 +395,16 @@ describe.each(EACH_MATRIX)('%s:%s: integration tests', (eventSourceName, framewo
   })
 
   test('set-cookie', async () => {
+    const now = new Date(2022, 7, 11, 3, 30, 30)
+    const maxAge = 3000
+    const expires = new Date(+now + maxAge)
+    const expectedExpires = expires.toUTCString()
+
+    jest.useFakeTimers('modern')
+    jest.setSystemTime(now)
+
     router.get('/cookie', (req, res) => {
+      res.cookie('Zoo', 'boo', { domain: 'mafoo.com', secure: true, httpOnly: true, sameSite: 'Strict', maxAge })
       res.cookie('Foo', 'bar', { domain: 'example.com', secure: true, httpOnly: true, sameSite: 'Strict' })
       res.cookie('Fizz', 'buzz')
       res.json({})
@@ -408,6 +417,7 @@ describe.each(EACH_MATRIX)('%s:%s: integration tests', (eventSourceName, framewo
     const response = await serverlessExpressInstance(event)
 
     const expectedSetCookieHeaders = [
+      `Zoo=boo; Max-Age=3; Domain=mafoo.com; Path=/; Expires=${expectedExpires}; HttpOnly; Secure; SameSite=Strict`,
       'Foo=bar; Domain=example.com; Path=/; HttpOnly; Secure; SameSite=Strict',
       'Fizz=buzz; Path=/'
     ]
@@ -423,10 +433,23 @@ describe.each(EACH_MATRIX)('%s:%s: integration tests', (eventSourceName, framewo
       statusCode: 200
     })
 
+    jest.useRealTimers()
+
     switch (eventSourceName) {
       case 'azureHttpFunctionV4':
       case 'azureHttpFunctionV3':
         expectedResponse.cookies = [
+          {
+            domain: 'mafoo.com',
+            httpOnly: true,
+            name: 'Zoo',
+            path: '/',
+            sameSite: 'Strict',
+            secure: true,
+            value: 'boo',
+            maxAge: maxAge / 1000,
+            expires
+          },
           {
             domain: 'example.com',
             httpOnly: true,

diff --git a/src/event-sources/azure/http-function-runtime-v3.js b/src/event-sources/azure/http-function-runtime-v3.js
@@ -64,7 +64,7 @@ function getResponseToHttpFunction ({ statusCode, body, headers = {}, isBase64En
       }
 
       if (parsedCookie['max-age']) {
-        cookie.maxAge = parsedCookie['max-age']
+        cookie.maxAge = +parsedCookie['max-age']
       }
 
       if (parsedCookie.samesite) {
@@ -73,7 +73,7 @@ function getResponseToHttpFunction ({ statusCode, body, headers = {}, isBase64En
 
       if (parsedCookie.expires && typeof parsedCookie.expires === 'string') {
         cookie.expires = new Date(parsedCookie.expires)
-      } else if (parsedCookie.expires && typeof value === 'number') {
+      } else if (parsedCookie.expires && typeof parsedCookie.expires === 'number') {
         cookie.expires = parsedCookie.expires
       }