Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure Cookie - Handle single or multiple cookies at once #525

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

XavM
Copy link
Contributor

@XavM XavM commented Jun 6, 2022

headers['set-cookie'] can be a string of one cookie, or an array of cookies
headerCookies should always be an array

Issue #, if available:

Description of changes:

Checklist

  • Tests have been added and are passing
  • Documentation has been updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

headers['set-cookie'] can be a string of one cookie, or an array of cookies
headerCookies should always be an array
Copy link
Collaborator

@brettstack brettstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XavM for the fix!

@brettstack
Copy link
Collaborator

brettstack commented Jun 7, 2022

We have a failing test https://github.com/vendia/serverless-express/runs/6771767461?check_suite_focus=true. Are you able to fix?

@brettstack brettstack merged commit d10f49a into CodeGenieApp:mainline Jun 7, 2022
github-actions bot pushed a commit that referenced this pull request Jun 7, 2022
## [4.8.2](v4.8.1...v4.8.2) (2022-06-07)

### Bug Fixes

* **azure-function:** handle single or multiple cookies at once ([#525](#525)) ([d10f49a](d10f49a))
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

🎉 This PR is included in version 4.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

OneDev0411 added a commit to OneDev0411/serverless-express that referenced this pull request Mar 16, 2023
## [4.8.2](CodeGenieApp/serverless-express@v4.8.1...v4.8.2) (2022-06-07)

### Bug Fixes

* **azure-function:** handle single or multiple cookies at once ([#525](CodeGenieApp/serverless-express#525)) ([d10f49a](CodeGenieApp/serverless-express@d10f49a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants