Skip to content

Fix Azure Cookie - Handle single or multiple cookies at once #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Fix Azure Cookie - Handle single or multiple cookies at once #525

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d4c2be
Fix Azure Cookie - Handle single or multiple cookies at once
XavM Jun 6, 2022
bc2c1c2
Merge branch 'mainline' into mainline
brettstack Jun 7, 2022
e5f79de
Fix tests - No more "response.cookies: []" when no cookie
XavM Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/event-sources/azure/http-function-runtime-v3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,13 @@ function getResponseToHttpFunction ({ statusCode, body, headers = {}, isBase64En
}

const cookies = []
const headerCookies = headers['set-cookie']

// headers['set-cookie'] can be a string of one cookie, or an array of cookies
// headerCookies should always be an array
const headerCookies = [].concat(headers['set-cookie'] || [])

// Convert 'set-cookie' to Azure Function 3.x cookie object array
// https://github.com/Azure/azure-functions-nodejs-worker/blob/v3.x/types/index.d.ts#L150
if (headerCookies) {
if (headerCookies.length > 0) {
for (const headerCookie of headerCookies) {
const parsedCookie = parseCookie(headerCookie)
const nameValueTuple = headerCookie.split(';')[0].split('=')
Expand Down