Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: content-length was not matching the body after an array to string conversion #130

Closed
wants to merge 5 commits into from
Closed

Fix: content-length was not matching the body after an array to string conversion #130

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b2ef6b
Close socket when running locally
guerrerocarlos Jan 7, 2018
9e35b47
Fix: content-length was not matching the body after an array to strin…
JonathanJonathanJonathan Mar 8, 2018
98c2abb
Check added that only resets the content-length header if it exists
JonathanJonathanJonathan Mar 8, 2018
cee42f5
Only reset the body length if response body is base64 encoded
JonathanJonathanJonathan Mar 8, 2018
6ac5f1a
Merge branch 'master' of https://github.com/guerrerocarlos/aws-server…
JonathanJonathanJonathan Mar 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion index.js
View file
Open in desktop
Expand Up @@ -82,9 +82,18 @@ function forwardResponseToApiGateway(server, response, context) {
const contentType = getContentType({ contentTypeHeader: headers['content-type'] })
const isBase64Encoded = isContentTypeBinaryMimeType({ contentType, binaryMimeTypes: server._binaryTypes })
const body = bodyBuffer.toString(isBase64Encoded ? 'base64' : 'utf8')

// Set the proper body length for base64 encoded responses
if(isBase64Encoded && typeof headers['content-length'] !== "undefined") {
headers['content-length'] = body.length.toString()
}

const successResponse = {statusCode, body, headers, isBase64Encoded}

context.succeed(successResponse)
context.succeed(successResponse);
if (context.local && server && server.close) {
server.close();
}
})
}

Expand All @@ -98,6 +107,9 @@ function forwardConnectionErrorResponseToApiGateway(server, error, context) {
}

context.succeed(errorResponse)
if (context.local && server && server.close) {
server.close();
}
}

function forwardLibraryErrorResponseToApiGateway(server, error, context) {
Expand All @@ -110,6 +122,9 @@ function forwardLibraryErrorResponseToApiGateway(server, error, context) {
}

context.succeed(errorResponse)
if (context.local && server && server.close) {
server.close();
}
}

function forwardRequestToNodeServer(server, event, context) {
Expand Down