fix: make sure to strip also base path non pathParameter #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When define resource `/users/${proxy+}`, request to `/users/123` is path as `/123`. But when
mapping `/users`, request to `/users` is path as `/users` not `/`. It is not symmetry.
BREAKING CHANGE: A handler of defined resource not use pathParameter be also less able to get base
path.
fix CodeGenieApp#377
|
@brettstack @brett-vendia |
|
Thanks @fossamagna is this a breaking change? |
|
@brettstack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #377
Description of changes:
When define resource
/users/${proxy+}, request to/users/123is path as/123. But when mapping/users, request to/usersis path as/usersnot/. It is not symmetry.BREAKING CHANGE: A handler of defined resource not use pathParameter be also less able to get base path.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.