Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team splitting doesn't work #271

Open
blerner opened this issue Jan 27, 2023 · 1 comment
Open

Team splitting doesn't work #271

blerner opened this issue Jan 27, 2023 · 1 comment
Labels

Comments

@blerner
Copy link
Collaborator

blerner commented Jan 27, 2023

We have a schema requirement that InlineComments have non-nil grade fields. When we split a team, we create a comment to acknowledge that, with a grade_id = 0, which corresponds to a nonexistent Grade...but it's technically not nil and so passes the database schema. We can make the belongs_to :grade be optional: true in InlineComment, which bypasses this check...but we might consider also making grade be nilable after all...

@blerner blerner added the bug label Jan 27, 2023
@blerner
Copy link
Collaborator Author

blerner commented Jan 27, 2023

I suspect this will affect Mark as Plagiarized as well.

blerner pushed a commit to blerner/bottlenose that referenced this issue Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant