Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for ECMAScript modules #239

Merged
merged 2 commits into from Dec 23, 2022

Conversation

0xricksanchez
Copy link
Contributor

@0xricksanchez 0xricksanchez commented Dec 21, 2022

This is not yet a full solution as full ES6 projects won't get instrumented yet.
Loading projects that (partially) rely on ES6 won't crash anymore though

Note: A follow up PR will attempt to resolve the remaining problems

@0xricksanchez 0xricksanchez marked this pull request as draft December 21, 2022 12:30
@0xricksanchez 0xricksanchez force-pushed the FUZZ-388-support-ECMAScript-modules branch from 9c0d590 to fd4effd Compare December 21, 2022 13:16
@0xricksanchez
Copy link
Contributor Author

Ended up removing a lot of the package-lock.json files that were left as artifacts in the example folder.
Additionally, I'm not quite sure why the CI fails. It looks like one of the recent auto merges to main broke things?
The log indicates the python3 .msi installer failed to clean up after a successful installation.

@0xricksanchez 0xricksanchez marked this pull request as ready for review December 21, 2022 14:02
@0xricksanchez
Copy link
Contributor Author

Looks like we may not need to the python3 install at all.

@bertschneider
Copy link
Contributor

I also did the .gitignore and pipeline changes in #204. Apparently the new GitHub Action windows runners contain Python 3, so we can remove that step in the pipeline.

Copy link
Contributor

@bertschneider bertschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great step towards ESM support!

examples/jpeg_es6/package.json Outdated Show resolved Hide resolved
examples/protobufjs/package.json Outdated Show resolved Hide resolved
packages/core/cli.ts Show resolved Hide resolved
packages/core/core.ts Outdated Show resolved Hide resolved
packages/core/core.ts Outdated Show resolved Hide resolved
packages/core/cli.ts Outdated Show resolved Hide resolved
packages/core/cli.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/core/cli.ts Outdated Show resolved Hide resolved
packages/jest-runner/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@0xricksanchez 0xricksanchez force-pushed the FUZZ-388-support-ECMAScript-modules branch from ee18559 to fb005fd Compare December 23, 2022 08:56
Copy link
Contributor

@bertschneider bertschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thx for the contribution!

@0xricksanchez 0xricksanchez enabled auto-merge (squash) December 23, 2022 09:02
@0xricksanchez 0xricksanchez merged commit 0048593 into main Dec 23, 2022
@0xricksanchez 0xricksanchez deleted the FUZZ-388-support-ECMAScript-modules branch December 23, 2022 09:22
0xricksanchez added a commit that referenced this pull request Dec 23, 2022
The last PR #239 should have included these changes to begin with,
somehow they got lost on the wire. The introduction of a new interface
called `FuzzTarget` caused a name conflict with a similarly named struct
field within `options`.
This PR ships a change that resolves this conflict.. whoops 🧐

Authored-by: 0xricksanchez <christopher.krah@code-intelligence.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants