Add done callback pattern support to fuzzer #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertschneider
requested review from
oetr,
kyakdan and
a team
and removed request for
oetr and
kyakdan
bertschneider
force-pushed
the
FUZZ-445-done-callback
branch
from
0f04f64
to
e85cd54
Compare
oetr
reviewed
Nov 29, 2022
bertschneider
force-pushed
the
FUZZ-445-done-callback
branch
from
e85cd54
to
5767d9b
Compare
bertschneider
force-pushed
the
FUZZ-445-done-callback
branch
2 times, most recently
from
c7c729e
to
23b6bf3
Compare
|
This PR got bigger than expected, due to some sneaked in cleanups. Sorry in advance 😬 |
bertschneider
force-pushed
the
FUZZ-445-done-callback
branch
from
23b6bf3
to
795ee41
Compare
oetr
approved these changes
Dec 21, 2022
The callback function name was renamed in our fork of libFuzzer.
In general package-lock.json files should be committed to the repository. In case of the example projects we don't want fixed versions but build them with the current fuzzer and it's dependencies. This leads to constant merge conflicts without much value. Hence, lock files of the example projects should be ignored.
"compile" rebuilds the whole project in case of compilation errors. This is very annoying during development. "build" on the other hand simply fails in case of errors, which is much quicker.
Allow a fuzz target to request a done callback as second parameter. If used, the fuzz target has to invoke the done callback to report its finished execution and request the next input.
bertschneider
force-pushed
the
FUZZ-445-done-callback
branch
from
795ee41
to
5714ab3
Compare
Jest supports sync, async and callback based tests.
bertschneider
force-pushed
the
FUZZ-445-done-callback
branch
from
5714ab3
to
de0cd02
Compare
Windows runners are already shipped with Python.
bertschneider
force-pushed
the
FUZZ-445-done-callback
branch
from
de0cd02
to
57b4065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a fuzz target to request a done callback as second parameter. If
used, the fuzz target has to invoke the done callback to report its
finished execution and request the next input.