Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding filter for tags #379

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

ADStrovers
Copy link

Creates two bars of tag filters for the project page. One for Technology tags and one for Cause tags.

I am not 100% sure why the old commits are being recommited.. If someone knows a fix I am more than happy to fix it! I don't foresee any issues with them though as they will already have taken effect in master.

@@ -0,0 +1,18 @@
window.onload = function() {
var tags = [];
var href = window.location.origin + window.location.pathname

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

} else {
window.location.href = href +"?tags=" + this.value;
}
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon.

tags = document.getElementsByClassName("tag_radio");

for (var i = 0; i < tags.length; i++) {
tags[i].addEventListener("click", tagLoop)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

} else {
window.location.href = href +"?tags=" + this.value;
}
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon.

@@ -11,4 +11,24 @@ def project_tags_link_list(project, type)
link_to tag.name, projects_path(tags: tag.name)
end.join(', ').html_safe
end

def projects_tech_and_cause_tags_lists(projects_array)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment Branch Condition size for projects_tech_and_cause_tags_lists is too high. [15.26/15]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants