Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: table actions #69

Merged
merged 20 commits into from
Apr 21, 2023
Merged

feat: table actions #69

merged 20 commits into from
Apr 21, 2023

Conversation

mgkprod
Copy link
Contributor

@mgkprod mgkprod commented Apr 17, 2023

This resolves #63.

@mgkprod mgkprod changed the base branch from master to develop April 17, 2023 13:24
app/Http/Controllers/RepositoryController.php Outdated Show resolved Hide resolved
app/Http/Controllers/PullRequestController.php Outdated Show resolved Hide resolved
resources/js/Pages/Repositories/RepositoryIndex.jsx Outdated Show resolved Hide resolved
app/Http/Controllers/RepositoryController.php Outdated Show resolved Hide resolved
app/Http/Controllers/PullRequestController.php Outdated Show resolved Hide resolved
resources/js/Pages/PullRequests/PullRequestIndex.jsx Outdated Show resolved Hide resolved
@geeksesi
Copy link
Collaborator

@vassilidev @mgkprod
could you please check the code, specially the change in the Models ( about a attribute )

@vassilidev
Copy link
Collaborator

For me, its good, can be better to handle the future but for now it work ! @mgkprod @geeksesi

@vassilidev vassilidev self-requested a review April 21, 2023 09:50
Copy link

@mariorocha-infraspeak mariorocha-infraspeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job guys 👍

Copy link
Collaborator

@vassilidev vassilidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -15,7 +16,8 @@
*/
class Repository extends Model
{
use SoftDeletes;
use SoftDeletes,
HasPermissions;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to

use SoftDeletes;
use HasPermissions;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to fix it now. only take care. it's better syntax. ❤️

@geeksesi
Copy link
Collaborator

awesome guys.
@mgkprod thank you for your contribution, hope to see your PRs again 😉😍

@geeksesi geeksesi merged commit 20adbed into CodeReviewPals:develop Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add action on tables
4 participants