Categoryencoding (#46)

* revision for catencoding pr * fixed tests and reviewer reccomendations * fixed changed files for clean pr * fixed indentation and linting error * fixed return statement in preprocessing function
CodeSmithDSMLProjects · Oct 3, 2022 · c9f3a1f · c9f3a1f
1 parent b14736b
commit c9f3a1f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/tfjs-layers/src/layers/preprocessing/preprocessing_utils.ts b/tfjs-layers/src/layers/preprocessing/preprocessing_utils.ts
@@ -74,11 +74,11 @@ export function encodeCategoricalInputs(inputs: Tensor|Tensor[],
     return binCounts;
   }
 
-  if(weights === null || weights === undefined) {
-    throw new ValueError(
-      `When outputMode is 'tfIdf', weights must be provided.`
-      );
-  } else {
+  if (weights) {
     return mul(binCounts, weights);
+  } else {
+      throw new ValueError(
+        `When outputMode is 'tfIdf', weights must be provided.`
+      );
   }
 }