[Feature] Apply CSS to the review list #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saseungmin
commented
Apr 7, 2021
•
saseungmin
commented
- Apply Average rating for study reviews with CSS
- Separated into AverageReview Component
- 리뷰 작성 후 리뷰에 대한 후처리 action 추가
- Apply Average rating for study reviews with CSS
- Separated into AverageReview Component
- 리뷰 작성 후 리뷰에 대한 후처리 action 추가
saseungmin
commented
Apr 7, 2021
Comment on lines
+140
to
173
|
|
||
| setGroupReview(state, { payload: review }) { | ||
| const { group } = state; | ||
|
|
||
| if (group.reviews) { | ||
| return { | ||
| ...state, | ||
| group: { | ||
| ...group, | ||
| reviews: [ | ||
| { | ||
| ...review, | ||
| createDate: new Date().toString(), | ||
| }, | ||
| ...group.reviews, | ||
| ], | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| return { | ||
| ...state, | ||
| group: { | ||
| ...group, | ||
| reviews: [ | ||
| { | ||
| ...review, | ||
| createDate: new Date().toString(), | ||
| }, | ||
| ], | ||
| }, | ||
| }; | ||
| }, | ||
| }, |
There was a problem hiding this comment.
이 부분은 각 그룹에 대한 스터디 후기에 대한 후처리 부분인데 immer를 사용하면 더 깔끔하게 작성할 수 있을 듯 싶다..
This was referenced Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.