[Feature] NotFound(404) 페이지를 구현하라 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 존재하지 않는 페이지로 이동한 경우 - 존재하지 않는 페이지에서 "홈으로" 버튼을 클릭한 경우
- 공통 ErrorScreenTemplate를 구현 - NotFoundPage 구현 - 404 이미지를 만듬
- SetNotFound, resetError 액션 구현 - useNotFound 커스텀 훅 구현
- ErrorBoundary를 적용하고 NotFoundPage를 적용 및 알수없는 오류 발생시 Unknown Error 페이지 적용 - App에 ErrorBoundary 적용 및 HeaderContainer 삭제
- matchMedia 의존성으로 인한 테스트 수정
- `import '../../util/__mocks__/matchMedia';` 추가
- Login, Main, Register, Write 페이지에 HeadCotainer 추가
saseungmin
changed the title
saseungmin
commented
Jul 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import '../../util/__mocks__/matchMedia';추가