Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply css to study list #8

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Conversation

saseungmin
Copy link
Collaborator

@saseungmin saseungmin commented Nov 19, 2020

๐Ÿš€ ์ง„ํ–‰ ์‚ฌํ•ญ

  • ์Šคํ„ฐ๋”” ๋ชฉ๋ก ๊ฐ„๋‹จํ•˜๊ฒŒ ๊พธ๋ฏธ๊ธฐ
  • ํƒœ๊ทธ(#) ๊พธ๋ฏธ๊ธฐ
  • ๊ฐ„๋‹จํ•œ ๋ฐ˜์‘ํ˜• styled component ๋งŒ๋“ค๊ธฐ

1

- Apply Styled components
- css base to studyList components
- Add palette and Responsive Styled component
@saseungmin saseungmin added the enhancement New feature or request label Nov 19, 2020
@saseungmin saseungmin mentioned this pull request Nov 19, 2020
11 tasks
@hannut91
Copy link

hannut91 commented Nov 20, 2020

๋ฒŒ์จ ๋ฌด์Šจ ์•ฑ์ธ์ง€ ๋ชจ์–‘์ด ๋ณด์ด๋Š” ๊ฒƒ ๊ฐ™์•„์š” ใ…Žใ…Ž ๋งˆ๊ฐ ์ผ์ž์— ๋ช‡์ผ์ด ๋‚จ์•˜๋Š”์ง€ ๋ณด์—ฌ์ฃผ๋Š”๊ฑด ์–ด๋–จ๊นŒ์š”? ์‚ฌ์šฉ์ž๊ฐ€ ์ค‘์š”ํ•œ ์Šคํ„ฐ๋””์— ๋†“์น˜์ง€ ์•Š๋„๋ก ํ•˜๊ธฐ ์œ„ํ•ด์„œ์š” ใ…Žใ…Ž

ํ•ต์‹ฌ ๊ธฐ๋Šฅ์€ ์•„๋‹ˆ๋ผ์„œ ์ด๋ฒˆ์ฃผ ์•ˆ์— ๊ฒฐ๊ณผ๋ฅผ ๋ณด์—ฌ์ฃผ๊ธฐ ์œ„ํ•ด ์‹œ๊ฐ„์ด ๋ถ€์กฑํ•˜๋‹ค๋ฉด ๋‚˜์ค‘์— ์ถ”๊ฐ€ํ•ด๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” ใ…Žใ…Ž

Comment on lines +21 to +25
color: ${palette.teal[7]};
background:${palette.gray[1]};
&:hover {
color: ${palette.teal[5]};
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ƒ‰๊น” ๋ชฉ๋ก์„ ๋งŒ๋“ค์–ด ๋†“๊ณ  ์ƒ‰๊น”์„ ์‚ฌ์šฉํ•˜์‹  ๊ฒƒ ๊ฐ™์•„์š” ใ…Žใ…Ž ์™œ TagsWrapper์˜ ์ƒ‰๊น”์ด teal[7]์ธ์ง€๋Š” ์ดํ•ดํ•˜๊ธฐ ์–ด๋ ค์šด ๊ฒƒ ๊ฐ™์•„์š”. ์ด ์ƒ‰์ƒ์ด ์–ด๋–ค ์ด์œ ๋กœ ์ด ์ƒ‰์œผ๋กœ ๊ฒฐ์ •๋˜์—ˆ๋Š”์ง€ ์˜๋ฏธ๋ฅผ ๋“œ๋Ÿฌ๋‚ด์ฃผ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”. ๊ทธ๋ž˜์•ผ ๋‹ค๋ฅธ ๊ณณ์—์„œ ์ƒ‰๊น”์„ ์‚ฌ์šฉํ•  ๋•Œ ๋” ์ข‹์„ ๊ฑฐ ๊ฐ™์•„์š”.

๋””์ž์ธ์„ ํ•  ๋•Œ ๋ฌด๋ถ„๋ณ„ํ•˜๊ฒŒ ์ƒ‰๊น”์„ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์ด ์•„๋‹Œ ์ •ํ•ด์ง„ ์ƒ‰๊น”๋“ค์„ ์ •์˜๋ฅผ ํ•˜๋Š”๋ฐ main ์ƒ‰๊น” sub์ƒ‰๊น” ๋“ฑ๋“ฑ์„ ์ •ํ•˜๋Š”๋ฐ
๋ฉ”์ธ ์ƒ‰๊น”์ด๋ผ๋˜์ง€ ํ˜น์€ ๊ฐ•์กฐ ์ƒ‰๊น”์ด๋ผ๋˜์ง€ ๋” ์˜๋ฏธ๋ฅผ ๋“œ๋Ÿฌ๋‚ด๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ํ˜„์žฌ ์ด๋Ÿฐ์‹์œผ๋กœ ์ƒ‰์ƒ ์ˆœ์„œ๋Œ€๋กœ ๋˜์–ด์žˆ๋Š” ๋ถ€๋ถ„์„
    2
const palette = {
  tagMain: '#f8f9fa',
  tagHover: '#66d9e8',
  // ...
}

export default palette;
  • ์ด๋Ÿฐ์‹์œผ๋กœ ๊ฐ ์ƒ‰์ƒ์˜ ์˜๋ฏธ๋ฅผ ๋“œ๋Ÿฌ๋‚ด์„œ ์‚ฌ์šฉํ•˜๋ผ๋Š” ๋ง์”€์ด์‹ ๊ฑด๊ฐ€์š”?? ๐Ÿค”

@saseungmin
Copy link
Collaborator Author

๋ฒŒ์จ ๋ฌด์Šจ ์•ฑ์ธ์ง€ ๋ชจ์–‘์ด ๋ณด์ด๋Š” ๊ฒƒ ๊ฐ™์•„์š” ใ…Žใ…Ž ๋งˆ๊ฐ ์ผ์ž์— ๋ช‡์ผ์ด ๋‚จ์•˜๋Š”์ง€ ๋ณด์—ฌ์ฃผ๋Š”๊ฑด ์–ด๋–จ๊นŒ์š”? ์‚ฌ์šฉ์ž๊ฐ€ ์ค‘์š”ํ•œ ์Šคํ„ฐ๋””์— ๋†“์น˜์ง€ ์•Š๋„๋ก ํ•˜๊ธฐ ์œ„ํ•ด์„œ์š” ใ…Žใ…Ž

ํ•ต์‹ฌ ๊ธฐ๋Šฅ์€ ์•„๋‹ˆ๋ผ์„œ ์ด๋ฒˆ์ฃผ ์•ˆ์— ๊ฒฐ๊ณผ๋ฅผ ๋ณด์—ฌ์ฃผ๊ธฐ ์œ„ํ•ด ์‹œ๊ฐ„์ด ๋ถ€์กฑํ•˜๋‹ค๋ฉด ๋‚˜์ค‘์— ์ถ”๊ฐ€ํ•ด๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” ใ…Žใ…Ž

@saseungmin saseungmin merged commit 1b8a1bc into main Nov 20, 2020
@saseungmin saseungmin deleted the add-styled-component-study-list branch June 16, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants