Add interviews header #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kwonmory
commented
Aug 28, 2020
•
kwonmory
commented
- add interviews header
- design interviews header
- change NotFoundPage styled style to object
- fix NotFoundPage function name...
- change NotFoundPage styled style to object - fix NotFoundPage function name...
|
오 근데 저 햄스터 이미지 사용해도 되는 이미지겠죠? ㅎㅎ; |
|
저 햄스터(애비츄)는 어떤 분께서 블로그에 파워포인트로 템플릿 공유하신거 부분만 따와서 사용했는데.. |
hannut91
reviewed
Aug 28, 2020
| <Wrapper> | ||
| <div> | ||
| <TitleStyled> | ||
| {quiz?.title || '인터뷰즈_'} |
Comment on lines
+11
to
+17
| function renderQuizHeader({ PATH, button = null, quiz = null }) { | ||
| return render( | ||
| <MemoryRouter> | ||
| <QuizHeader path={PATH} onExit={button} quiz={quiz} /> | ||
| </MemoryRouter>, | ||
| ); | ||
| } |
There was a problem hiding this comment.
음.. null을 허용한다는게 조금 마음이 걸리네요. null을 허용하는 순간 null인지 아닌지 항상 검사해야되서 복잡성이 증가하거든요
There was a problem hiding this comment.
아... 그렇군요. 전 또 그냥 값이 없으면 null로 초기화라고 해야지 하고 넣었는데, 원래 값의 기본값으로 초기화 처리 해야겠어요.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.