-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4주차 과제- 고양이 장난감가게 만들기 #76
Merged
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
f7d8b9e
기본 작성
jdalma 18cc4b3
DB 연동
jdalma 16c5fd5
계층 이름 수정
jdalma f62d9be
Service findAll 메소드 테스트 작성
jdalma 22f4dd8
ResourceNotFoundException 커스텀 예외 추가
jdalma e0ce4a1
Advice , ErrorResult 추가
jdalma b3bb1f1
ProductService findById메서드 테스트 작성
jdalma bd99da7
Update app/src/test/java/com/codesoom/assignment/application/ProductS…
jdalma 66c4118
메서드 네이밍 수정 newProduct
jdalma 3430a2c
ProductService 주석 추가
jdalma 12102bd
JPA ddl-auto : create로 수정
jdalma 2acf43a
Product DTO 추가
jdalma ab8d812
NullResourceException 커스텀 예외 추가
jdalma 591eb17
ProductDTO 추가
jdalma 136e58b
BadRequestException 커스텀 예외 추가
jdalma cf3c24c
ProductService save 메서드 테스트 추가
jdalma f9947fd
필요없는 import 삭제
jdalma 275e607
ProductController 테스트 추가
jdalma d84bf20
NullResourceException 삭제
jdalma b728d01
'@Transactional(readOnly = true)' 설정
jdalma 161d33c
Setter 추가
jdalma 85c0854
update 메서드 적용
jdalma ec0ab94
ProductService 조회 기능 메서드 분리
jdalma 9752bad
application 패키지 service로 변경
jdalma 370d4c5
ProductServiceDI Repository 주입받아서 테스트
jdalma a3e4bb5
ProductControllerTest Service 기능 분리
jdalma be1afbc
Product Setter 제거
jdalma acb2e00
findAll 메서드 불필요한 형변환 제거
jdalma 9e7514a
findAll메서드 반환 타입 주석 수정
jdalma e6b26cb
deleteById 테스트 코드 추가
jdalma e93c0ef
Optional map 사용
jdalma 969de04
테스트 추가
jdalma 2f12058
Update app/src/main/java/com/codesoom/assignment/service/ProductServi…
jdalma File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
app/src/main/java/com/codesoom/assignment/exception/NullResourceException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package com.codesoom.assignment.exception; | ||
|
||
public class NullResourceException extends RuntimeException{ | ||
|
||
} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
널포인터예외와 어떻게 다른가요?!
주석에 설명이 있으면 좋겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아.. 테스트 코드를 작성하면서 필요할 것 같았는데.. 왜 추가했는지 기억이 나지 않네요 ㅠㅠ
주석이 필요한 이유를 몸소 느꼇네요 ㅎㅎ