Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4주차 과제- 고양이 장난감가게 만들기 #76

Merged
merged 33 commits into from
Oct 3, 2022
Merged

4주차 과제- 고양이 장난감가게 만들기 #76

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
f7d8b9e
기본 작성
jdalma Aug 22, 2022
18cc4b3
DB 연동
jdalma Aug 23, 2022
16c5fd5
계층 이름 수정
jdalma Aug 23, 2022
f62d9be
Service findAll 메소드 테스트 작성
jdalma Aug 23, 2022
22f4dd8
ResourceNotFoundException 커스텀 예외 추가
jdalma Aug 23, 2022
e0ce4a1
Advice , ErrorResult 추가
jdalma Aug 23, 2022
b3bb1f1
ProductService findById메서드 테스트 작성
jdalma Aug 23, 2022
bd99da7
Update app/src/test/java/com/codesoom/assignment/application/ProductS…
jdalma Aug 24, 2022
66c4118
메서드 네이밍 수정 newProduct
jdalma Aug 24, 2022
3430a2c
ProductService 주석 추가
jdalma Aug 24, 2022
12102bd
JPA ddl-auto : create로 수정
jdalma Aug 24, 2022
2acf43a
Product DTO 추가
jdalma Aug 24, 2022
ab8d812
NullResourceException 커스텀 예외 추가
jdalma Aug 24, 2022
591eb17
ProductDTO 추가
jdalma Aug 24, 2022
136e58b
BadRequestException 커스텀 예외 추가
jdalma Aug 24, 2022
cf3c24c
ProductService save 메서드 테스트 추가
jdalma Aug 24, 2022
f9947fd
필요없는 import 삭제
jdalma Aug 24, 2022
275e607
ProductController 테스트 추가
jdalma Aug 24, 2022
d84bf20
NullResourceException 삭제
jdalma Aug 25, 2022
b728d01
'@Transactional(readOnly = true)' 설정
jdalma Aug 25, 2022
161d33c
Setter 추가
jdalma Aug 26, 2022
85c0854
update 메서드 적용
jdalma Aug 26, 2022
ec0ab94
ProductService 조회 기능 메서드 분리
jdalma Aug 26, 2022
9752bad
application 패키지 service로 변경
jdalma Aug 26, 2022
370d4c5
ProductServiceDI Repository 주입받아서 테스트
jdalma Aug 26, 2022
a3e4bb5
ProductControllerTest Service 기능 분리
jdalma Aug 26, 2022
be1afbc
Product Setter 제거
jdalma Aug 27, 2022
acb2e00
findAll 메서드 불필요한 형변환 제거
jdalma Aug 27, 2022
9e7514a
findAll메서드 반환 타입 주석 수정
jdalma Aug 27, 2022
e6b26cb
deleteById 테스트 코드 추가
jdalma Aug 27, 2022
e93c0ef
Optional map 사용
jdalma Aug 28, 2022
969de04
테스트 추가
jdalma Aug 28, 2022
2f12058
Update app/src/main/java/com/codesoom/assignment/service/ProductServi…
jdalma Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/main/java/com/codesoom/assignment/dto/ProductDTO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import lombok.Getter;
import lombok.ToString;

import javax.validation.constraints.NotNull;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

591eb17 커밋의 제목과 실제 한 일이 달라요! 또한 @NotNull 은 사용하지 않는 것처럼 보이네요!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커밋 제목 , import 부분 신경쓰도록 하겠습니다 ㅎㅎ



@ToString
@Getter
Expand All @@ -19,7 +21,7 @@ public class ProductDTO {
@JsonCreator
public ProductDTO(@JsonProperty("name") String name,
@JsonProperty("maker") String maker,
@JsonProperty("price")int price,
@JsonProperty("price") int price,
@JsonProperty("fileName") String fileName) {
this.name = name;
this.maker = maker;
Expand Down