Spring security 설정을 구현했습니다. (작업중) #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Security 를 활용할 때 유저권한을 흭득하여 조회할 수 있도록 수정
…UserAuthentication 파라미터 추가
hannut91
reviewed
Apr 21, 2023
Comment on lines
+30
to
+31
| http.csrf() | ||
| .disable() |
There was a problem hiding this comment.
이번기회에 csrf란 무엇이고 왜 여기서는 disable하는지 알아보는 것도 좋겠습니다
| ClaimData claimData = authenticationService.parseToken(accessToken); | ||
| Long userId = claimData.getUserId(); | ||
| UserType userType = claimData.getUserType(); | ||
| request.setAttribute("userId", userId); |
| request.setAttribute("userId", userId); | ||
|
|
||
| // 인증 | ||
| Authentication authentication = new UserAuthentication(userId,userType); |
There was a problem hiding this comment.
지금은 토큰안에 userId, userType만을 가지고 있는데, 이게 늘어날 가능성이 있어보여요. 그렇다면 여기 넘겨줘야할 값들이 많아질 것 같은데, 객체를 넘기는 것도 대안이 될 것 같습니다
Comment on lines
+36
to
+47
| if (authorization != null) { | ||
| String accessToken = authorization.substring("Bearer ".length()); | ||
| ClaimData claimData = authenticationService.parseToken(accessToken); | ||
| Long userId = claimData.getUserId(); | ||
| UserType userType = claimData.getUserType(); | ||
| request.setAttribute("userId", userId); | ||
|
|
||
| // 인증 | ||
| Authentication authentication = new UserAuthentication(userId,userType); | ||
| SecurityContext context = SecurityContextHolder.getContext(); | ||
| context.setAuthentication(authentication); | ||
| } |
There was a problem hiding this comment.
여기서 하는 일이 많아 보이네요. 예를들어 만약 clameData가 값이 추가되거나 삭제될 경우 이 부분이 변경되어야겠네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0418
0419