Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy lint fixes #170

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Easy lint fixes #170

merged 1 commit into from
Nov 16, 2023

Conversation

MichaelTamaki
Copy link
Contributor

Easy lint fixes

Before

@MichaelTamaki ➜ /workspaces/HIERR (lint-fixes) $ npm run lint

> hierr@0.1.0 lint
> next lint

info  - Loaded env from /workspaces/HIERR/.env

./src/components/censusmap.tsx
15:1  Warning: Import "Ref" is only used as types.  @typescript-eslint/consistent-type-imports
16:1  Warning: All imports in the declaration are only used as types. Use `import type`.  @typescript-eslint/consistent-type-imports
64:6  Warning: React Hook useEffect has a missing dependency: 'censusTractDB'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
67:53  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
191:38  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any

./src/components/survey/demographicssurvey.tsx
71:6  Warning: React Hook useEffect has a missing dependency: 'surveyCompletedDB'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
127:5  Warning: React Hook useCallback has missing dependencies: 'postUserAnswer' and 'surveyData'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps

./src/components/survey/dropdownAnswers.tsx
41:6  Warning: React Hook useEffect has missing dependencies: 'getFilteredWorkshopsByCounty' and 'setDisabled'. Either include them or remove the dependency array. If 'setDisabled' changes too often, find the parent component that defines it and wrap that definition in useCallback.  react-hooks/exhaustive-deps

./src/components/zipcode.tsx
39:6  Warning: React Hook useEffect has a missing dependency: 'zipCodeDB'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
49:6  Warning: React Hook useCallback has missing dependencies: 'removeUserZipCode' and 'zipcode'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps

./src/pages/api/export.js
34:28  Warning: 'next' is defined but never used.  @typescript-eslint/no-unused-vars

./src/pages/polissurvey.tsx
3:21  Warning: 'useState' is defined but never used.  @typescript-eslint/no-unused-vars

info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules

After

@MichaelTamaki ➜ /workspaces/HIERR (lint-fixes) $ npm run lint

> hierr@0.1.0 lint
> next lint

info  - Loaded env from /workspaces/HIERR/.env

./src/components/censusmap.tsx
65:6  Warning: React Hook useEffect has a missing dependency: 'censusTractDB'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
68:53  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
192:38  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any

./src/components/survey/demographicssurvey.tsx
71:6  Warning: React Hook useEffect has a missing dependency: 'surveyCompletedDB'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
127:5  Warning: React Hook useCallback has missing dependencies: 'postUserAnswer' and 'surveyData'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps

./src/components/survey/dropdownAnswers.tsx
41:6  Warning: React Hook useEffect has missing dependencies: 'getFilteredWorkshopsByCounty' and 'setDisabled'. Either include them or remove the dependency array. If 'setDisabled' changes too often, find the parent component that defines it and wrap that definition in useCallback.  react-hooks/exhaustive-deps

./src/components/zipcode.tsx
39:6  Warning: React Hook useEffect has a missing dependency: 'zipCodeDB'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
49:6  Warning: React Hook useCallback has missing dependencies: 'removeUserZipCode' and 'zipcode'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps

info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules

@MichaelTamaki MichaelTamaki requested a review from a team as a code owner October 31, 2023 04:51
@vercel
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hierr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 8:35am

Copy link
Collaborator

@avenmia avenmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants