Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React base jeff #46

Merged
merged 3 commits into from
Jul 9, 2019
Merged

Conversation

jeffslofish
Copy link

This code implements a search results page that is using dynamic data from the server, based upon the existing react code from the react-base branch.

Related to #41

@badwolfbit
Copy link
Collaborator

The dropdown is currently being addressed, thanks @jeffslofish for adding functionality to the search component
Screenshot 2019-07-09 17 04 47

We're getting appropriate layout exactly like handlebars card component @CodeWritingCow

Screenshot 2019-07-09 17 04 39

@badwolfbit badwolfbit merged commit 316b4dd into CodeWritingCow:react-base Jul 9, 2019
@CodeWritingCow
Copy link
Owner

Thanks @jeffslofish for your React implementation! The search results page looks great. Thank you.

One observation: Perhaps we can replace Fetch with Axios in Search.jsx. With Axios, we can make HTTP requests in fewer lines of code. We won't need to call .json() on the response.

Axios is included in this repo's package.json. Let me give this a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants